std.bigint: support construction from Int128#10948
std.bigint: support construction from Int128#10948Prashant-900 wants to merge 6 commits intodlang:masterfrom
Conversation
Fixes issue 10945.
|
Thanks for your pull request and interest in making D better, @Prashant-900! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
|
You'd likely need an |
|
Added assignment from Int128 and unit tests for a sanity check. While doing so, I noticed an inconsistency: This works, but: does not. Assigning an int to Int128 also fails. Is this expected behavior, or should this be raised as an issue? |
Removed an unnecessary blank line before the constructor.
|
@ibuclaw Do you consider the added unittests to be sufficient? |
This PR adds explicit BigInt constructors for Int128 resolving issue #10945.