Skip to content

Acknowledge the reality of securityContext handling#198

Open
tdg5 wants to merge 1 commit intodocker-mailserver:masterfrom
tdg5:make-security-context-more-true
Open

Acknowledge the reality of securityContext handling#198
tdg5 wants to merge 1 commit intodocker-mailserver:masterfrom
tdg5:make-security-context-more-true

Conversation

@tdg5
Copy link
Copy Markdown

@tdg5 tdg5 commented Apr 1, 2026

This has been touched on elsewhere, but I wanted to make it official to try to save other people time and confusion.

This PR does 2.5 things:

  1. Cleans up trailing whitespace
  2. Adds a coalesce that prioritizes taking securityContext config from .deployment.securityContext, but falls back to .securityContext to try to maintain existing mappings.
    1. I'd vote for removing the coalesce as part of 6.x release.
  3. Replaces the unused default securityContext config with an empty object to try to maintain existing default configuration and be honest about what's really happening upon deployment.

If you disagree with any of these choices, let me know. Feedback is welcome.

Related:

@tdg5 tdg5 requested a review from funkypenguin as a code owner April 1, 2026 17:49
# set those unless you're using a secret
#RELAY_PASSWORD:

securityContext:
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified against v5.1.1 that this does not work. The pod won't start with this config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant