history logs: print error summary at end of output#3756
Draft
thompson-shaun wants to merge 1 commit intodocker:masterfrom
Draft
history logs: print error summary at end of output#3756thompson-shaun wants to merge 1 commit intodocker:masterfrom
thompson-shaun wants to merge 1 commit intodocker:masterfrom
Conversation
When a build fails, `history logs` now prints an error summary after all progress output, matching the error detail already shown by `history inspect`. This includes the error message, source location (e.g. the failing Dockerfile line), logs from the failed vertex, and a stack trace hint. Particularly useful for cache key computation failures where no vertex logs appear during the main log replay. Extracts loadBuildErrorOutput and printErrorDetails as shared helpers so both commands use the same formatting logic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Shaun Thompson <30006198+thompson-shaun@users.noreply.github.com>
f8f42b2 to
e6f2d47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3132
When a build fails,
history logsnow prints an error summary afterall progress output, matching the error detail already shown by
history inspect. This includes the error message, source location(e.g. the failing Dockerfile line), logs from the failed vertex, and
a stack trace hint. Particularly useful for cache key computation
failures where no vertex logs appear during the main log replay.
Extracts loadBuildErrorOutput and printErrorDetails as shared helpers
so both commands use the same formatting logic.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Before:
(no indication of what went wrong — you'd have to run history inspect separately)
After: