opts: improve and cleanup MountOpt tests #6768
Open
+323
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR refactors and improves the MountOpt tests in the opts package. The changes consolidate multiple small test functions into well-organized table-driven tests, improve test coverage, and make the test suite easier to maintain.
Changes:
- Consolidated error tests into a single
TestMountOptErrorsfunction with comprehensive test cases - Refactored readonly and volume-nocopy tests into table-driven formats with expanded coverage
- Added comprehensive
TestMountOptVolumeOptionstest covering volume labels, drivers, and options - Renamed
TestMountOptSetBindNoErrorBindtoTestMountOptSourceTargetAliasesfor clarity - Removed duplicate
TestMountOptSetVolumeNoError(aliases are mount-type agnostic)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
improve_mountopts_tests
branch
from
540f7f0 to
a6e8f7d
Compare
…test Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Setting the source and target paths is not tied to the mount-type, so these tests where covering the same code. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
improve_mountopts_tests
branch
from
a6e8f7d to
77e02a9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)