pkg/compose: remove dependency on github.com/docker/buildx/driver#13563
Merged
ndeloof merged 1 commit intodocker:mainfrom Jan 29, 2026
Merged
pkg/compose: remove dependency on github.com/docker/buildx/driver#13563ndeloof merged 1 commit intodocker:mainfrom
ndeloof merged 1 commit intodocker:mainfrom
Conversation
The driver.Auth interface was describing the configfile.GetAuthConfig implementation; define a local interface instead of using buildx's definition as an intermediate. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jan 29, 2026
Comment on lines
+263
to
+267
| type authProvider interface { | ||
| GetAuthConfig(registryHostname string) (clitypes.AuthConfig, error) | ||
| } | ||
|
|
||
| func encodedAuth(ref reference.Named, configFile authProvider) (string, error) { |
Member
Author
There was a problem hiding this comment.
Alternatively, this could just use the configfile itself as argument, but perhaps it was meant to be able to stub out / use different implementations;
Suggested change
| type authProvider interface { | |
| GetAuthConfig(registryHostname string) (clitypes.AuthConfig, error) | |
| } | |
| func encodedAuth(ref reference.Named, configFile authProvider) (string, error) { | |
| func encodedAuth(ref reference.Named, configFile *configfile.ConfigFile) (string, error) { |
Member
Author
|
test-failure is probably a flakey |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ndeloof
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver.Auth interface was describing the configfile.GetAuthConfig implementation; define a local interface instead of using buildx's definition as an intermediate.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did