-
Notifications
You must be signed in to change notification settings - Fork 5.8k
update cagent-action to latest (with better permissions) #13665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
derekmisler
wants to merge
3
commits into
docker:main
Choose a base branch
from
derekmisler:update-cagent-action-to-latest-with-better-permis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−34
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,26 @@ | ||
| name: PR Review | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [opened, ready_for_review] | ||
| issue_comment: | ||
| issue_comment: # Enables /review command in PR comments | ||
| types: [created] | ||
| pull_request_review_comment: | ||
| pull_request_review_comment: # Captures feedback on review comments for learning | ||
| types: [created] | ||
| pull_request: # Triggers auto-review on PR open (same-repo branches only; fork PRs use /review) | ||
| types: [ready_for_review, opened] | ||
derekmisler marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Serialize reviews per PR; do not cancel in-progress runs | ||
| # so no review is silently dropped mid-execution. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.issue.number }} | ||
| cancel-in-progress: false | ||
|
Comment on lines
-11
to
-15
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is already baked into the action. |
||
| permissions: | ||
| contents: read # Required at top level so `GITHUB_TOKEN` for `issue_comment` events can read repository contents. | ||
|
|
||
| jobs: | ||
| review: | ||
| # Only run on the upstream repo (not forks) to prevent credential leaks. | ||
| # Skip draft PRs (ready_for_review will fire when promoted). | ||
| # Skip bot actors to avoid reviewing Dependabot and automation PRs. | ||
| # Require collaborator-level access for comment-triggered events. | ||
| # Only trigger on PR comments, not plain issue comments. | ||
| if: >- | ||
| github.repository == 'docker/compose' && | ||
| (github.event_name != 'pull_request_target' || github.event.pull_request.draft == false) && | ||
| (github.event_name == 'pull_request_target' || | ||
| (github.event_name == 'issue_comment' && | ||
| github.event.issue.pull_request && | ||
| contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)) || | ||
| (github.event_name == 'pull_request_review_comment' && | ||
| contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association))) && | ||
| !endsWith(github.actor, '[bot]') | ||
|
Comment on lines
-19
to
-33
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also now included in the action. |
||
| uses: docker/cagent-action/.github/workflows/review-pr.yml@3a12dbd0c6cd7dda3d4e05f24f0143c9701456de # v1.2.13 | ||
| uses: docker/cagent-action/.github/workflows/review-pr.yml@dba0ca51938c78afb363625363c50582243218d6 # v1.3.1 | ||
| # Scoped to the job so other jobs in this workflow aren't over-permissioned | ||
| permissions: | ||
| contents: read # Read repository files and PR diffs | ||
| pull-requests: write # Post review comments and approve/request changes | ||
| issues: write # Create security incident issues if secrets are detected in output | ||
| checks: write # (Optional) Show review progress as a check run on the PR | ||
| secrets: | ||
| ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }} | ||
| CAGENT_ORG_MEMBERSHIP_TOKEN: ${{ secrets.CAGENT_ORG_MEMBERSHIP_TOKEN }} | ||
| CAGENT_REVIEWER_APP_ID: ${{ secrets.CAGENT_REVIEWER_APP_ID }} | ||
| CAGENT_REVIEWER_APP_PRIVATE_KEY: ${{ secrets.CAGENT_REVIEWER_APP_PRIVATE_KEY }} | ||
| permissions: | ||
| contents: read # to fetch code | ||
| pull-requests: write # to post review comments | ||
| issues: write # to reply to issue/PR comments | ||
| checks: write # to update check statuses | ||
| CAGENT_ORG_MEMBERSHIP_TOKEN: ${{ secrets.CAGENT_ORG_MEMBERSHIP_TOKEN }} # PAT with read:org scope; gates auto-reviews to org members only | ||
| CAGENT_REVIEWER_APP_ID: ${{ secrets.CAGENT_REVIEWER_APP_ID }} # GitHub App ID; reviews appear as your app instead of github-actions[bot] | ||
| CAGENT_REVIEWER_APP_PRIVATE_KEY: ${{ secrets.CAGENT_REVIEWER_APP_PRIVATE_KEY }} # GitHub App private key; paired with App ID above | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.