updated GHA with new checks:write permission#1974
Merged
derekmisler merged 1 commit intodocker:mainfrom Mar 6, 2026
Merged
Conversation
Signed-off-by: Derek Misler <derek.misler@docker.com>
rumpl
approved these changes
Mar 6, 2026
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR updates the GitHub Actions workflow to move permissions from the workflow level to the job level, following GitHub Actions security best practices (principle of least privilege). The changes add a new checks: write permission at the job level.
Changes analyzed:
- Removed workflow-level permissions (contents, pull-requests, issues)
- Added job-level permissions with the same permissions plus
checks: write
Findings: No critical or notable issues found in the changed code.
The YAML syntax is correct, and the permission restructuring is a positive security improvement. The new checks: write permission allows the reusable workflow to create and manage check runs via the GitHub Checks API, which appears to be the intended functionality based on the PR title.
✅ Ready to merge (human approval recommended)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds
checks: writeso the review agent can create a "PR Review" check run on PRs