Skip to content

updated GHA with new checks:write permission#1974

Merged
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:updated-gha-with-new-checkswrite-permission
Mar 6, 2026
Merged

updated GHA with new checks:write permission#1974
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:updated-gha-with-new-checkswrite-permission

Conversation

@derekmisler
Copy link
Contributor

@derekmisler derekmisler commented Mar 6, 2026

adds checks: write so the review agent can create a "PR Review" check run on PRs

Signed-off-by: Derek Misler <derek.misler@docker.com>
@derekmisler derekmisler marked this pull request as ready for review March 6, 2026 21:10
@derekmisler derekmisler requested a review from a team as a code owner March 6, 2026 21:10
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟢 APPROVE

This PR updates the GitHub Actions workflow to move permissions from the workflow level to the job level, following GitHub Actions security best practices (principle of least privilege). The changes add a new checks: write permission at the job level.

Changes analyzed:

  • Removed workflow-level permissions (contents, pull-requests, issues)
  • Added job-level permissions with the same permissions plus checks: write

Findings: No critical or notable issues found in the changed code.

The YAML syntax is correct, and the permission restructuring is a positive security improvement. The new checks: write permission allows the reusable workflow to create and manage check runs via the GitHub Checks API, which appears to be the intended functionality based on the PR title.

✅ Ready to merge (human approval recommended)

@derekmisler derekmisler merged commit 7caf905 into docker:main Mar 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants