Fix cobra command and rename more things from cagent to docker agent#1979
Open
dgageot wants to merge 1 commit intodocker:mainfrom
Open
Fix cobra command and rename more things from cagent to docker agent#1979dgageot wants to merge 1 commit intodocker:mainfrom
dgageot wants to merge 1 commit intodocker:mainfrom
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR successfully renames 'cagent' to 'docker-agent' throughout the codebase and fixes Cobra command configuration. The changes are primarily cosmetic (renaming) with one notable behavior change: the root command now defaults to running the 'run' subcommand when invoked without arguments, instead of showing help.
Key Changes:
- Removed deprecated binary name (
cagent) from build configuration - Updated all CLI examples and documentation strings
- Consolidated telemetry initialization into
PersistentPreRunE - Changed root command default behavior to execute
runsubcommand - Simplified Cobra command structure by removing runtime binary name detection
Verification:
All changes reviewed. No bugs detected in the modified code. The code handles edge cases appropriately (e.g., the 'run' command is guaranteed to exist when Find() is called).
No issues found in the changed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cagentandcagent.exe