fix: prevent panic when home directory cannot be determined#493
Open
pulkit-999 wants to merge 1 commit intodocker:mainfrom
Open
fix: prevent panic when home directory cannot be determined#493pulkit-999 wants to merge 1 commit intodocker:mainfrom
pulkit-999 wants to merge 1 commit intodocker:mainfrom
Conversation
Member
|
If the home directory is misconfigured and the software cannot determine it anyway, why would a panic be the incorrect behavior? |
Author
|
Missing home directories can happen in minimal containers, CI environments, or misconfigured systems. Expected runtime conditions should return errors, not panic. This provides better user experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, getConfigPath() can return an empty string if the home directory cannot be determined (e.g., in minimal containers or
misconfigured systems). This empty string is then passed to path.Join(), causing a panic: "runtime error: makeslice: len out of range".
This change makes getConfigPath() return an error instead, and adds proper error handling in the caller. The error is wrapped with context to help users understand what went wrong.