Use full commit SHAs for referenced GitHub Actions#245
Merged
Conversation
Signed-off-by: Remy Suen <remy.suen@docker.com>
Collaborator
Author
|
Merging despite the build failures so that we can get the SHAs in place which is our first priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The referenced GitHub Actions do not use full commit SHAs.
Proposed Solution
Switching over to reference the commit SHAs will help improve stability and ensure builds are generally reproducible.
Proof of Work
No obvious way to prove this without exercising the CI.