Skip to content

Facility api fix in case the adapter returns null #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabor-lbl merged 2 commits into from
Feb 11, 2026
Merged

Facility api fix in case the adapter returns null #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
821a681
Facility api fix in case the adapter returns null
gabor-lbl Feb 11, 2026
1953879
hide facility/ from swagger
gabor-lbl Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions app/routers/facility/facility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from fastapi import Depends, Query, Request
from fastapi import Depends, Query, Request, HTTPException

from ...types.http import forbidExtraQueryParams
from ...types.scalars import StrictDateTime
Expand All @@ -10,13 +10,17 @@


@router.get("", responses=DEFAULT_RESPONSES, operation_id="getFacility", response_model_exclude_none=True,)
@router.get("/", responses=DEFAULT_RESPONSES, operation_id="getFacilityWithSlash", response_model_exclude_none=True, include_in_schema=False,)
async def get_facility(
request: Request,
modified_since: StrictDateTime = Query(default=None),
_forbid=Depends(forbidExtraQueryParams("modified_since")),
) -> models.Facility:
"""Get facility information"""
return await router.adapter.get_facility(modified_since=modified_since)
facility = await router.adapter.get_facility(modified_since=modified_since)
if not facility:
raise HTTPException(status_code=404, detail="Facility not found")
return facility


@router.get("/sites", responses=DEFAULT_RESPONSES, operation_id="getSites", response_model_exclude_none=True,)
Expand All @@ -41,4 +45,7 @@ async def get_site(
_forbid=Depends(forbidExtraQueryParams("modified_since")),
) -> models.Site:
"""Get site by ID"""
return await router.adapter.get_site(site_id=site_id, modified_since=modified_since)
site = await router.adapter.get_site(site_id=site_id, modified_since=modified_since)
if not site:
raise HTTPException(status_code=404, detail="Site not found")
return site