Skip to content

Accept Memory as IEC format for job submission #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juztas wants to merge 2 commits into from
Closed

Accept Memory as IEC format for job submission #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaab7cd
Accept Memory as IEC format for job submission
juztas Feb 11, 2026
53388b6
Add strict pattern requirement for memory in job spec
juztas Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions app/routers/compute/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from enum import IntEnum
from typing import Annotated

from pydantic import ConfigDict, Field, StrictBool, field_serializer
from pydantic import ConfigDict, Field, StrictBool, field_serializer, field_validator

from ...types.base import IRIBaseModel

Expand All @@ -17,7 +17,30 @@ class ResourceSpec(IRIBaseModel):
cpu_cores_per_process: Annotated[int | None, Field(ge=1, description="Number of CPU cores to allocate per process")] = None
gpu_cores_per_process: Annotated[int | None, Field(ge=1, description="Number of GPU cores to allocate per process")] = None
exclusive_node_use: Annotated[StrictBool, Field(description="Whether to request exclusive use of allocated nodes")] = True
memory: Annotated[int | None, Field(ge=1, description="Amount of memory to allocate in bytes")] = None
memory: Annotated[str | None, Field(min_length=4, pattern=r"^[1-9]\d*(MiB|GiB)$", examples=["1GiB", "512MiB", "64GiB"], description="Amount of memory to allocate in IEC binary format (e.g. '512MiB', '4GiB')")] = None
Copy link
Contributor

@gabor-lbl gabor-lbl Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts:

  • should we also add larger memory units (Tib, etc) for "future-proofing"?
  • should we use an object here to explicitly represent things: { value=100, unit="Gib" } (where unit is an enum)?
  • what usecase does this code help? Sure, people can now send 256Gib but if you need to work with these values, you'll need encode/decode type code when sending/receiving the values. Not a strong opinion, but it's worth thinking about.


@field_validator("memory")
@classmethod
def validate_memory(cls, v):
"""Validate memory string in IEC binary format (e.g. '512MiB', '4GiB') and convert to bytes."""
if v is None:
return v

v = v.strip()
units = {"mib": 2**20, "gib": 2**30}

lower = v.lower()
for unit, multiplier in units.items():
if lower.endswith(unit):
number_part = lower[: -len(unit)].strip()
try:
value = int(number_part)
except ValueError as ex:
raise ValueError("Memory value must be an integer followed by MiB or GiB") from ex
if value < 1:
raise ValueError("Memory value must be a positive integer")
return value * multiplier
raise ValueError("Memory must use units MiB or GiB (e.g. '512MiB', '4GiB')")


class JobAttributes(IRIBaseModel):
Expand Down