Skip to content

fix(types): restore React 19 JSX compatibility for Carousel#912

Open
dohooo wants to merge 3 commits intomainfrom
caspian/fix-848-react19-jsx-pr2
Open

fix(types): restore React 19 JSX compatibility for Carousel#912
dohooo wants to merge 3 commits intomainfrom
caspian/fix-848-react19-jsx-pr2

Conversation

@dohooo
Copy link
Copy Markdown
Owner

@dohooo dohooo commented Mar 30, 2026

Summary

  • update Carousel's exported generic component signature to return React.ReactNode
  • add a dedicated React 19 JSX consumer type regression and wire it into yarn types
  • keep the fix free of any casts, skipLibCheck changes, or weakened tsconfig settings

Fixes #848.

Verification

  • yarn types:react19
  • yarn types
  • yarn test --runInBand src/components/Carousel.test.tsx

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: 97950f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 30, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
react-native-reanimated-carousel Ignored Ignored Preview Mar 30, 2026 2:24am

Request Review

@dosubot
Copy link
Copy Markdown

dosubot Bot commented Mar 30, 2026

Related Documentation

1 document(s) may need updating based on files changed in this PR:

react-native-reanimated-carousel

CONTRIBUTING /react-native-reanimated-carousel/blob/main/CONTRIBUTING.md — ⏳ Awaiting Merge

Note: You must be authenticated to accept/decline updates.

How did I do? Any feedback?  Join Discord

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.32%. Comparing base (fec99d7) to head (97950f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files          37       37           
  Lines        1040     1040           
  Branches      362      364    +2     
=======================================
  Hits          877      877           
  Misses         67       67           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Carousel' cannot be used as a JSX component.

1 participant