fix(android): Prevents Promise.reject crash with null arguments#1329
Merged
fix(android): Prevents Promise.reject crash with null arguments#1329
Conversation
Ensures that `Promise.reject` calls in the Android module do not crash when provided with `null` values for code or message. This is achieved by providing default values when `null` is passed, preventing unexpected behavior and improving the stability of the module.
aliberski
force-pushed
the
promise-reject-crash
branch
from
b770b99 to
9f8e35c
Compare
This was referenced Feb 17, 2026
ivannikcevicc
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that
Promise.rejectcalls in the Android module do not crash when provided withnullvalues for code or message. This is achieved by providing default values whennullis passed, preventing unexpected behavior and improving the stability of the module.This PR: