feat(jobs): add MsBuildProperty for escaped MSBuild properties#3055
Merged
timcassell merged 1 commit intodotnet:masterfrom Mar 22, 2026
Merged
feat(jobs): add MsBuildProperty for escaped MSBuild properties#3055timcassell merged 1 commit intodotnet:masterfrom
timcassell merged 1 commit intodotnet:masterfrom
Conversation
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2719.
What
new MsBuildArgument(value, escapeSpecialCharacters: true).MsBuildProperty : MsBuildArgumentfor/p:name=value(joins multiple values with;and escapes automatically).ToString()when escaping is enabled.MsBuildProperty.Why
MSBuild treats
;as a property separator in/p:so values likeDefineConstants=TEST1;TEST2must be escaped (eg%3B) to work reliably.Verification
dotnet test tests/BenchmarkDotNet.Tests/BenchmarkDotNet.Tests.csproj -c Release -f net8.0 --filter FullyQualifiedName~MsBuildArgumentTestsdotnet test tests/BenchmarkDotNet.IntegrationTests.ManualRunning/BenchmarkDotNet.IntegrationTests.ManualRunning.csproj -c Release -f net8.0 --filter FullyQualifiedName~MsBuildArgumentTestsContext
This follows the combined direction discussed in #2730 / #2732 (opt-in escaping + a dedicated property type).