Skip to content

[3.0] Replace NameTrimmer with equivalent IdentifySharedPrefixes mod #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Exanite wants to merge 43 commits into
base: develop/3.0
Choose a base branch
from
Draft

[3.0] Replace NameTrimmer with equivalent IdentifySharedPrefixes mod #2557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
3ac76f2
Update OpenAL name overrides to match the 2 character acronym thresho…
Exanite Mar 24, 2026
634e736
Start of feature/nested-struct-name-affixes branch
Exanite Mar 24, 2026
35f0f59
Cleanup leftover return statement
Exanite Mar 25, 2026
cd2ccfd
Split TransformHandles into two mods
Exanite Mar 25, 2026
4b119b2
Rename UseDSL to UseDsl
Exanite Mar 25, 2026
f3900b9
Cleanup unused property in TransformHandles
Exanite Mar 25, 2026
851c3ff
Cleanup usages of redundant collections expressions in TransformHandles
Exanite Mar 25, 2026
2f018ff
Add NameAffixer.AddResolvedNameAffix() for handling compound names
Exanite Mar 27, 2026
50a4115
Use AddResolvedNameAffix for extracted function pointer delegate types
Exanite Mar 27, 2026
8388878
Use AddResolvedNameAffix for extracted nested structs and remove name…
Exanite Mar 27, 2026
674c61a
Rename resolved affix to referenced affix and add parsing code for re…
Exanite Mar 27, 2026
d2ae93d
Add extra ConsecutiveNumbers test case documenting that Xs between nu…
Exanite Mar 27, 2026
d51a68e
Fix incorrect declarationOrder implementation
Exanite Mar 27, 2026
a30ac45
Change Prettify to not prefix identifiers starting with numbers
Exanite Mar 28, 2026
fb98f40
Change the list and order of INameTrimmers used to be statically conf…
Exanite Jan 15, 2026
68153ff
Replace now outdated comment
Exanite Mar 28, 2026
e0fb52e
Move PrettifyNamesTrimmer higher up in the class to make it more obvi…
Exanite Mar 28, 2026
044c84b
Remove INameTrimmer.Version
Exanite Mar 28, 2026
e9b2377
Add PrefixIfStartsWithNumberTrimmer
Exanite Mar 28, 2026
464703c
Remove TrimmerBaseline config option
Exanite Mar 28, 2026
adf4eee
Rename INameTrimmer to INameProcessor and update rest of codebase
Exanite Mar 28, 2026
f321238
Simplify name affixer name processor names to be StripAffixesNameProc…
Exanite Mar 28, 2026
d8e808d
Shorten names a bit more for readability
Exanite Mar 28, 2026
6983172
Decide to only support references within the same scope depth
Exanite Mar 28, 2026
14d9d65
Restrict feature set of AddReferencedNameAffix even more for simplicity
Exanite Mar 28, 2026
0228a56
Implement referenced affixes and change how -Delegate types generated…
Exanite Mar 28, 2026
5a4b6cd
Update OpenAL name overrides in generator.json
Exanite Mar 30, 2026
16ba7ea
Update doc comment in ServiceCollectionExtensions to indicate removal…
Exanite Mar 30, 2026
3ced75c
Merge branch 'feature/update-openal-name-overrides' into feature/nest…
Exanite Mar 30, 2026
86e12c4
Update name overrides for OpenAL to match new Delegate type naming co…
Exanite Mar 30, 2026
2ecb6b1
Optimize comparison by hoisting the calculation
Exanite Mar 31, 2026
5788cb7
Add topological sort to ReapplyAffixesProcessor
Exanite Mar 31, 2026
e56b4cf
Improve error handling by checking for case where dependencies are no…
Exanite Mar 31, 2026
85e2461
Edit error message
Exanite Mar 31, 2026
0edec2b
Add test: PrettifyNamesTests.SuccessfullyUsesReferencedAffixes
Exanite Mar 31, 2026
aad7a0b
Use "SDL.gen.cs" for test document name
Exanite Mar 31, 2026
f200deb
Add tests for referenced affix behavior
Exanite Mar 31, 2026
6a791b0
Alphabetically sort the mod names
Exanite Mar 31, 2026
64fb7c6
Add start of IdentifySharedPrefixes mod
Exanite Mar 31, 2026
7e7442d
Work on IdentifySharedPrefixes
Exanite Mar 31, 2026
e416196
Remove ApplyPrettifyOnlyPipeline
Exanite Mar 31, 2026
2763385
Rename BreakIntoWords as SplitIntoWords
Exanite Mar 31, 2026
6160704
Remove the double legacy NameTrimmers
Exanite Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .silktouch/openal-clangsharp.stout
View file
Open in desktop
Binary file not shown.
Binary file modified .silktouch/vulkan-clangsharp.stout
View file
Open in desktop
Binary file not shown.
39 changes: 19 additions & 20 deletions generator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"AddIncludes",
"ClangScraper",
"MarkNativeNames",
"ExtractHandles",
"ExtractNestedTyping",
"TransformHandles",
"TransformFunctions",
Expand All @@ -59,8 +60,7 @@
"InputTestRoot": "tests/SDL"
},
"TransformHandles": {
"AssumeMissingTypesOpaque": true,
"UseDSL": true
"UseDsl": true
},
"TransformFunctions": {
"BoolTypes": {
Expand Down Expand Up @@ -228,6 +228,7 @@
"ChangeNativeClass",
"AddApiProfiles",
"MixKhronosData",
"ExtractHandles",
"ExtractNestedTyping",
"TransformHandles",
"InterceptNativeFunctions",
Expand Down Expand Up @@ -299,24 +300,20 @@
"NameOverrides": {
"ALContext": "ALContext",
"EFXEAXREVERBPROPERTIES": "EfxEaxReverbProperties",
"EFXEAXREVERBPROPERTIES_flReflectionsPan": "EfxEaxReverbPropertiesFlReflectionsPan",
"EFXEAXREVERBPROPERTIES_flLateReverbPan": "EfxEaxReverbPropertiesFlLateReverbPan",
"EFXEAXREVERBPROPERTIESflReflectionsPan": "EfxEaxReverbPropertiesFlReflectionsPan",
"EFXEAXREVERBPROPERTIESflLateReverbPan": "EfxEaxReverbPropertiesFlLateReverbPan",
"ALCcontextHandle": "ContextHandle",
"ALCdeviceHandle": "DeviceHandle",
"ALBUFFERCALLBACKTYPESOFT": "BufferCallbackSOFT",
"ALBUFFERCALLBACKTYPESOFTDelegate": "BufferCallbackDelegateSOFT",
"ALBUFFERCALLBACKTYPESOFTDelegate": "BufferCallbackSOFTDelegate",
"ALCEVENTPROCTYPESOFT": "ContextEventProcSOFT",
"ALCEVENTPROCTYPESOFTDelegate": "ContextEventProcDelegateSOFT",
"ALCEVENTPROCTYPESOFTDelegate": "ContextEventProcSOFTDelegate",
"ALEVENTPROCSOFT": "EventProcSOFT",
"ALEVENTPROCSOFTDelegate": "EventProcDelegateSOFT",
"ALEVENTPROCSOFTDelegate": "EventProcSOFTDelegate",
"ALDEBUGPROCEXT": "DebugProcEXT",
"ALDEBUGPROCEXTDelegate": "DebugProcDelegateEXT",
"ALDEBUGPROCEXTDelegate": "DebugProcEXTDelegate",
"LPALFOLDBACKCALLBACK": "FoldbackCallback",
"LPALFOLDBACKCALLBACKDelegate": "FoldbackCallbackDelegate",
"EAXSetDirect": "EAXSetDirect",
"EAXGetDirect": "EAXGetDirect",
"EAXGetBufferModeDirect": "EAXGetBufferModeDirect",
"EAXSetBufferModeDirect": "EAXSetBufferModeDirect"
"LPALFOLDBACKCALLBACKDelegate": "FoldbackCallbackDelegate"
},
"Affixes": {
"HandleType": {
Expand Down Expand Up @@ -351,8 +348,7 @@
"BenefitOfTheDoubtArrayTransformation": true
},
"TransformHandles": {
"AssumeMissingTypesOpaque": true,
"UseDSL": true
"UseDsl": true
},
"StripAttributes": {
"Remove": [
Expand All @@ -370,13 +366,15 @@
"AddIncludes",
"ClangScraper",
"MarkNativeNames",
"ExtractHandles",
"ExtractNestedTyping",
"TransformHandles",
"MixKhronosData",
"AddApiProfiles",
"InterceptNativeFunctions",
"TransformFunctions",
"TransformProperties",
"IdentifySharedPrefixes",
"PrettifyNames",
"TransformEnums",
"AddVTables",
Expand Down Expand Up @@ -423,15 +421,16 @@
}
},
"TransformHandles": {
"AssumeMissingTypesOpaque": true,
"UseDSL": true
"UseDsl": true
},
"PrettifyNames": {
"GlobalPrefixHints": ["PFN_vk","vk"],
"IdentifySharedPrefixes": {
"GlobalPrefixHints": ["PFN_vk", "vk"],
"PrefixOverrides": {
"VkPipelineCreateFlags2": "VK_PIPELINE_CREATE_2",
"VkMemoryDecompressionMethodFlagsEXT": "VK_MEMORY_DECOMPRESSION_METHOD"
},
}
},
"PrettifyNames": {
"NameOverrides": {
"numAABBs": "NumAabbs"
},
Expand Down
Loading