Conversation
Member
|
@copilot continue |
…Manager Agent-Logs-Url: https://github.com/dotnet/android/sessions/1eb1fc88-df89-4cb7-bd45-15187eea3776 Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Contributor
Author
Added the |
Copilot
AI
changed the title
[WIP] Add GetStaticMethodFallbackTypesCore override for TrimmableTypeMap
[TrimmableTypeMap] Add GetStaticMethodFallbackTypesCore override for desugared default interface methods
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the trimmable typemap runtime type manager for resolving Java 8+ desugared default interface method companion classes during JNI static method lookup, preventing runtime NoSuchMethodError when default interface methods are used.
Changes:
- Added
GetStaticMethodFallbackTypesCore()override toTrimmableTypeMapTypeManager. - Implemented desugar companion-class fallback name generation (
Desugar{Type}$_CCand{Type}$-CC) consistent withManagedTypeManager.
src/Mono.Android/Microsoft.Android.Runtime/TrimmableTypeMapTypeManager.cs
Show resolved
Hide resolved
…Core Agent-Logs-Url: https://github.com/dotnet/android/sessions/66cf81ea-433f-43ac-8c85-45bb0483a230 Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
GetStaticMethodFallbackTypesCoreoverride toTrimmableTypeMapTypeManagerto support Java 8+ default interface methods desugared by D8/R8.Problem
TrimmableTypeMapTypeManagerdid not overrideGetStaticMethodFallbackTypesCore(). Without this, calls to desugared default interface methods fail withNoSuchMethodErrorat runtime when using the trimmable type map. This affects any app using Java libraries with default interface methods (Java 8+ feature, very common in modern Android libraries like AndroidX).Fix
Added the same override that already exists in
ManagedTypeManagertoTrimmableTypeMapTypeManager:This generates two fallback type names for desugared companion classes (
Desugar{Type}$_CCand{Type}$-CC) so that JNI static method lookups on desugared default interface methods succeed at runtime.Tests
Added
TrimmableTypeMapTypeManagerTeststotests/Mono.Android-Tests/Mono.Android-Tests/Java.Interop/to verify the fallback type generation. The tests use a subclass ofTrimmableTypeMapTypeManager(accessible via the existingInternalsVisibleToinMono.Android) and cover three cases:android/app/Activity)Activity)com/example/package/MyInterface)