Restore separate custom init step parameters (fix regression from #1963)#1974
Merged
lbussell merged 1 commit intodotnet:mainfrom Feb 20, 2026
Merged
Conversation
…net#1963) PR dotnet#1963 inadvertently reverted the fix from dotnet#1954 due to a bad merge, re-combining customBuildInitSteps, customGenerateMatrixInitSteps, and customCopyBaseImagesInitSteps into customInitSteps. This caused init-imagebuilder.yml to skip the default ImageBuilder pull on Windows, breaking all Windows PR validation builds. Restores the separate parameter pattern so these steps run after init-common rather than through customInitSteps which bypasses ImageBuilder setup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lbussell
added a commit
to dotnet-docker-bot/dotnet-docker
that referenced
this pull request
Feb 20, 2026
Restores separate customBuildInitSteps, customGenerateMatrixInitSteps, and customCopyBaseImagesInitSteps parameters so they run after init-common rather than through customInitSteps, which was causing init-imagebuilder.yml to skip the default ImageBuilder pull on Windows. Fix: dotnet/docker-tools#1974 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mthalman
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1963 ("Update Image Builder tag reference") inadvertently reverted the fix from #1954 ("Separate custom init steps from job-specific init steps") due to a bad merge. This re-introduced the bug where Windows PR validation fails because
Microsoft.DotNet.ImageBuilder.exeis never downloaded.This is currently breaking the dotnet-docker nightly PR validation pipeline: dotnet/dotnet-docker#7046.
Changes
Restores the separate parameter pattern from #1954:
customBuildInitStepsinbuild-images.yml— injected afterinit-commoncustomGenerateMatrixInitStepsingenerate-matrix.yml— injected afterinit-commoncustomCopyBaseImagesInitStepsincopy-base-images.yml/copy-base-images-staging.yml— injected afterinit-commonThese steps run after ImageBuilder setup, not through
customInitStepswhich would bypass it.Related PRs