Fix parameter reference in TensorPrimitives.Hypot#12288
Closed
Fix parameter reference in TensorPrimitives.Hypot#12288
Conversation
Contributor
|
@@vcsjones - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an XML documentation remark for System.Numerics.Tensors.TensorPrimitives.Hypot<T> so it correctly references both input parameters (x and y) in the example expression.
Changes:
- Corrected the
<remarks>example fromT.Hypot(x[i], x[i])toT.Hypot(x[i], y[i]).
Contributor
|
@vcsjones This should be fixed in the runtime repo instead: https://github.com/dotnet/runtime/blob/591b3de9a58d8669f606533d50469e45a6b64198/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.Hypot.cs#L21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The remark for
TensorPrimitives.Hypotreferred toxtwice instead ofxandy.Before:
After