Skip to content

Fix parameter reference in TensorPrimitives.Hypot#12288

Closed
vcsjones wants to merge 1 commit intomainfrom
vcsjones/hypot-fix
Closed

Fix parameter reference in TensorPrimitives.Hypot#12288
vcsjones wants to merge 1 commit intomainfrom
vcsjones/hypot-fix

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Feb 6, 2026

Summary

The remark for TensorPrimitives.Hypot referred to x twice instead of x and y.

Before:

This method effectively computes destination[i] = T.Hypot(x[i], x[i]).

After

This method effectively computes destination[i] = T.Hypot(x[i], y[i]).

@vcsjones vcsjones requested a review from a team as a code owner February 6, 2026 21:33
Copilot AI review requested due to automatic review settings February 6, 2026 21:33
@dotnet-policy-service
Copy link
Contributor

@@vcsjones - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an XML documentation remark for System.Numerics.Tensors.TensorPrimitives.Hypot<T> so it correctly references both input parameters (x and y) in the example expression.

Changes:

  • Corrected the <remarks> example from T.Hypot(x[i], x[i]) to T.Hypot(x[i], y[i]).

@gewarren
Copy link
Contributor

gewarren commented Feb 6, 2026

@vcsjones This should be fixed in the runtime repo instead: https://github.com/dotnet/runtime/blob/591b3de9a58d8669f606533d50469e45a6b64198/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.Hypot.cs#L21

@gewarren gewarren closed this Feb 6, 2026
@vcsjones vcsjones deleted the vcsjones/hypot-fix branch February 6, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants