[release/10.0.1xx] [CI] Misc fixes by rolfbjarne · Pull Request #24896 · dotnet/macios

rolfbjarne · 2026-03-16T11:34:21Z

Misc CI fixes:

Backport of [tests] Update max simulator OS version. #24867
Backport of [CI] Move to provisionator via script and use SAS token auth #24893
Use Tahoe instead of Sequoia due to dotnet@9 fails to install on macOS 15 (Sequoia) Homebrew/homebrew-core#272535.
Backport of [tests] Fix CGRenderingBufferProviderTest.SizeProperty_DoesNotThrow to have consistent results. #24574
Backports of [tests] Add/improve logging in BitmapContextTest.CreateAdaptive. #24144, [tests] BitmapContextTest.AdaptiveTest to not crash. #24500, [tests] Fix crash in BitmapContextTest.CreateAdaptive_2 by computing correct buffer size. #24862 and [tests] Fix BitmapContextTest.CreateAdaptive_3/_4 crash due to undersized buffer #24920 to fix a test crash.

This fixes the following problem: * We default the max simulator version to the SDK version of an OS (currently 26.2) * However, iOS/tvOS 26.3 exists, and that's the simulator 'xcodebuild -downloadPlatform' installs with Xcode 26.3. * The max simulator version is what we use in xharness to decide which simulator to run tests in. * The result is that xharness will try to use/create a simulator for iOS 26.2, but that might not be possible (unless said simulator was already installed from before the current build), because it wasn't provisioned.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… iOS/tvOS 26.3 Replace xamvideotest.mp4 with a freshly-generated, well-formed H.264 Baseline video. The old video (created in 2015 by Mainconcept encoder) had non-standard dimensions (438x434, not multiples of 16) and produced codecBadDataErr (-8969) on iOS/tvOS 26.4 simulators where the decoder is stricter. The new video uses standard dimensions (320x240), H.264 Constrained Baseline profile, and is generated with ffmpeg to ensure well-formed NAL units. Also add WaitForAsynchronousFrames() after FinishDelayedFrames() in all async decode tests. FinishDelayedFrames() directs the session to emit all delayed frames, but WaitForAsynchronousFrames() is needed to block until all async callbacks have completed before checking assertions. Fixes #24844 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…n auth Replace all uses of the xamops.azdevex.provisionator-task.provisionator@3 AzDO task with a new provision.yml template that uses the provisionator-bootstrap.sh script with BosStorageMirror SAS token authorization. This bypasses dl.internalx.com entirely, which suffers from 502 timeouts under concurrent load (>10 parallel requests) due to sequential KeyVault token scanning hitting the 120s httpPlatform request timeout. The new approach: - Generates short-lived SAS tokens via AzurePowerShell@5 - Downloads provisionator directly from bosstoragemirror.blob.core.windows.net - Eliminates the dl.internalx.com bottleneck This follows the same pattern already adopted by the AgentCleanser and ClientTools.Provisionator pipelines. Note: The pipeline will need the 'Xamarin - RelEng (BosStorageMirror-Contributor-MI)' Azure service connection authorized for the macios pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add shellcheck disable directives for SC2220 (missing *) case in getopts) and SC2181 (indirect exit code check with $?) since this is an upstream script from ClientTools.Provisionator. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Backports CI changes to run Provisionator via a shared template + bootstrap script, switching authentication to short-lived BosStorageMirror SAS tokens (instead of the AzDO Provisionator task/GitHub token), to reduce dl.internalx.com timeout issues under load.

Changes:

Replaced direct xamops.azdevex.provisionator-task.provisionator@2 usages with a shared templates/common/provision.yml template.
Added templates/common/provision.yml to generate SAS tokens via AzureCLI and invoke a new provisionator-bootstrap.sh script.
Added provisionator-bootstrap.sh (and a local .gitignore) to download/cache Provisionator from BosStorageMirror and execute it.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tools/devops/automation/templates/windows/reserve-mac.yml	Switch Xcode provisioning to the shared provision template.
tools/devops/automation/templates/tests/build.yml	Switch test dependency provisioning to the shared provision template.
tools/devops/automation/templates/mac/build.yml	Switch (disabled) brew provisioning step to shared template wiring.
tools/devops/automation/templates/build/build.yml	Switch product/framework provisioning to shared template (preserving retry behavior).
tools/devops/automation/templates/common/provision.yml	New template: generate SAS tokens + invoke bootstrap script with env-based auth.
tools/devops/automation/scripts/provisionator-bootstrap.sh	New bootstrapper: download Provisionator from BosStorageMirror (SAS) and execute.
tools/devops/automation/scripts/.gitignore	Ignore extracted `_provisionator` cache directory.

You can also share your feedback on Copilot code review. Take the survey.

tools/devops/automation/templates/common/provision.yml

tools/devops/automation/scripts/provisionator-bootstrap.sh

…o have consistent results. (#24574) Use an autorelease pool to ensure object lifetime is consistent, and thus asserts work as expected.

1. Split the AdaptiveTest into 4 different tests to make it easier to figure out where crashes occur. 2. Use autorelease pools to have more consistent memory management. This means the OnReleaseInfo callbacks will be called during the test, so adjust accordingly. 3. Create a CGRenderingBufferProvider in OnAllocate callbacks. This seems to be what fixes the crash. This also makes it so that the calls to CGBitmapContext.ToImage() succeed, so adjust accordingly.

…correct buffer size. (#24862) The hardcoded 512-byte rendering buffer was far too small for a 256x256 adaptive bitmap context. Replace with the correct size computed from the adaptive parameters (AlignedBytesPerRow * Height) to avoid SIGSEGV in CGBitmapContextCreateImage when it tries to read beyond the buffer. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ized buffer (#24920) CreateAdaptive_3 and CreateAdaptive_4 used a hardcoded 512-byte buffer for a 256x256 adaptive bitmap context. When ToImage() called CGBitmapContextCreateImage, CoreGraphics tried to copy the bitmap data from this tiny buffer, reading past the allocation and causing a SIGSEGV. Fix CreateAdaptive_3 by computing the buffer size from parameters.AlignedBytesPerRow * parameters.Height (matching CreateAdaptive_2). Fix CreateAdaptive_4 by using a 1MB buffer, large enough for any 256x256 adaptive bitmap format. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2026-03-20T18:02:09Z

✅ [CI Build #dbbcc8f] Build passed (Build packages) ✅

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:04:43Z

✅ [PR Build #dbbcc8f] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:26:41Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:29:07Z

✅ [CI Build #dbbcc8f] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:41:29Z

💻 [CI Build #dbbcc8f] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:41:31Z

💻 [CI Build #dbbcc8f] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:42:57Z

💻 [CI Build #dbbcc8f] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:43:09Z

💻 [CI Build #dbbcc8f] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:43:10Z

💻 [CI Build #dbbcc8f] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T19:33:18Z

🔥 [CI Build #dbbcc8f] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 16 tests failed, 114 tests passed.

Failures

❌ linker tests

8 tests failed, 36 tests passed.

Failed tests

link sdk/iOS - simulator/Debug: Crashed
link sdk/iOS - simulator/Release: Crashed
link all/iOS - simulator/Debug: Crashed
link all/iOS - simulator/Release: Crashed
link all/iOS - simulator/Debug (don't bundle original resources): Crashed
trimmode copy/iOS - simulator/Debug: Crashed
trimmode copy/iOS - simulator/Release: Crashed
trimmode link/iOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

7 tests failed, 4 tests passed.

Failed tests

monotouch-test/iOS - simulator/Debug (ARM64): Crashed
monotouch-test/iOS - simulator/Release (NativeAOT, ARM64): Crashed
monotouch-test/iOS - simulator/Debug (managed static registrar): Crashed
monotouch-test/iOS - simulator/Release (managed static registrar, all optimizations): Crashed
monotouch-test/iOS - simulator/Release (NativeAOT, x64): Crashed
monotouch-test/iOS - simulator/Debug (interpreter): Crashed
monotouch-test/iOS - simulator/Release (interpreter): Crashed

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

1 tests failed, 14 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Release (static registrar): Failed (Test run failed.
Tests run: 3497 Passed: 3347 Inconclusive: 10 Failed: 1 Ignored: 149)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: dbbcc8ff55aaf2d7fc650580fd1759b1baa51e98 [PR build]

rolfbjarne and others added 14 commits March 12, 2026 10:57

Auto-format source code

6a88e7a

There's no tvOS 26.3 simulator.

1d0f6a4

Auto-format source code

f1901bc

Update tests.

1a34386

Update XML docs for CGFont.CreateWithFontName

703b61f

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Any of

deb809c

[CI] Move to provisionator 3

e71296c

Add provisionator_uri

0a38089

Remove files....

d94a6bc

Add .gitignore.

9c3a10e

rolfbjarne requested a review from Copilot March 16, 2026 11:34

rolfbjarne added the backported label Mar 16, 2026

rolfbjarne enabled auto-merge (squash) March 16, 2026 11:34

Copilot started reviewing on behalf of rolfbjarne March 16, 2026 11:35 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

tools/devops/automation/templates/common/provision.yml Show resolved Hide resolved

tools/devops/automation/scripts/provisionator-bootstrap.sh Show resolved Hide resolved

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Mar 16, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

[tests] Fix CGRenderingBufferProviderTest.SizeProperty_DoesNotThrow t…

d6665e4

…o have consistent results. (#24574) Use an autorelease pool to ensure object lifetime is consistent, and thus asserts work as expected.

Conversation

rolfbjarne commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 20, 2026

✅ [CI Build #dbbcc8f] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

✅ [PR Build #dbbcc8f] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

✅ [CI Build #dbbcc8f] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

💻 [CI Build #dbbcc8f] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

💻 [CI Build #dbbcc8f] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

💻 [CI Build #dbbcc8f] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

💻 [CI Build #dbbcc8f] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

💻 [CI Build #dbbcc8f] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

🔥 [CI Build #dbbcc8f] Test results 🔥

Test results

Failures

❌ linker tests

Failed tests

❌ monotouch tests (iOS)

Failed tests

❌ monotouch tests (MacCatalyst)

Failed tests

Successes

Uh oh!

Reviewers

Assignees

Labels

Projects

rolfbjarne commented Mar 16, 2026 •

edited

Loading