[dotnet-linker] Use [DynamicDependency] attributes instead of manual marking in MarkIProtocolHandler. by rolfbjarne · Pull Request #24931 · dotnet/macios

rolfbjarne · 2026-03-19T09:45:49Z

This makes it easier to move this code out of a custom linker step in the future.

Contributes towards #17693.

…marking in MarkIProtocolHandler. This makes it easier to move this code out of a custom linker step in the future. Contributes towards #17693.

Copilot

Pull request overview

This PR updates the dotnet-linker trimming pipeline to preserve protocol-related interface metadata via DynamicDependency attributes rather than manually marking protocol interfaces during linking, supporting the longer-term goal of removing custom linker steps (Issue #17693).

Changes:

Reworked MarkIProtocolHandler from a mark handler into a pre-mark linker step that injects DynamicDependency attributes.
Extended the dotnet-linker Profile helper APIs to quickly filter assemblies that are/ reference the platform assembly.
Added AppBundleRewriter helpers for creating and de-duplicating DynamicDependency attributes on static constructors, and moved MarkIProtocolHandler to run before MarkStep.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
tools/dotnet-linker/MarkIProtocolHandler.cs	Converts protocol preservation from manual marking to injected `DynamicDependency` before marking begins.
tools/dotnet-linker/Compat.cs	Adds helper methods to detect assemblies that reference the platform assembly.
tools/dotnet-linker/AppBundleRewriter.cs	Adds helpers for creating/adding `DynamicDependency` attributes onto static constructors and avoiding duplicates.
dotnet/targets/Xamarin.Shared.Sdk.targets	Moves `MarkIProtocolHandler` into the pre-mark custom steps list.

You can also share your feedback on Copilot code review. Take the survey.

tools/dotnet-linker/MarkIProtocolHandler.cs

tools/dotnet-linker/AppBundleRewriter.cs

This way we get validation of any xml docs in dotnet-linker.

…dependency-attributes-markiprotocolhandler

vs-mobiletools-engineering-service2 · 2026-03-20T11:42:56Z

✅ [CI Build #278c8dc] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 278c8dc8808974a7d71e6b42667378801be716f4 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T11:45:56Z

✅ [PR Build #278c8dc] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 278c8dc8808974a7d71e6b42667378801be716f4 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T11:57:46Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 278c8dc8808974a7d71e6b42667378801be716f4 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T12:09:16Z

✅ [CI Build #278c8dc] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 278c8dc8808974a7d71e6b42667378801be716f4 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-20T18:05:20Z

🚀 [CI Build #278c8dc] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 278c8dc8808974a7d71e6b42667378801be716f4 [PR build]

[dotnet-linker] Use [DynamicDependency] attributes instead of manual …

1a9742f

…marking in MarkIProtocolHandler. This makes it easier to move this code out of a custom linker step in the future. Contributes towards #17693.

rolfbjarne requested a review from Copilot March 19, 2026 09:45

Copilot AI reviewed Mar 19, 2026

View reviewed changes

Auto-format source code

53725f4

This comment has been minimized.

Sign in to view

Opt out & review

f7766bf

This comment has been minimized.

Sign in to view

rolfbjarne and others added 5 commits March 20, 2026 11:47

improvements

2399bc6

[tools] Enable xml doc generation for dotnet-linker.

4e79705

This way we get validation of any xml docs in dotnet-linker.

Merge remote-tracking branch 'origin/main' into dev/rolf/use-dynamic-…

6d19d4f

…dependency-attributes-markiprotocolhandler

simplify

e5e4199

Auto-format source code

278c8dc

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review March 20, 2026 16:45

rolfbjarne enabled auto-merge (squash) March 20, 2026 16:45

dalexsoto approved these changes Mar 20, 2026

View reviewed changes

Conversation

rolfbjarne commented Mar 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 20, 2026

✅ [CI Build #278c8dc] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 20, 2026

✅ [PR Build #278c8dc] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 20, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 20, 2026

✅ [CI Build #278c8dc] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 20, 2026

🚀 [CI Build #278c8dc] Test results 🚀

Test results

Tests counts

macOS tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants