Re-enable CoreCLR test variations on x64#24938
Closed
kotlarmilos wants to merge 1 commit intonet11.0from
Closed
Conversation
Remove the workaround that disabled CoreCLR test variations on x64 to verify if dotnet/runtime#122563 has been fixed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kotlarmilos
changed the title
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ [CI Build #acb222a] Build passed (Detect API changes) ✅Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
✅ [CI Build #acb222a] Build passed (Build packages) ✅Pipeline on Agent |
Member
|
@kotlarmilos could you re-create the pull request from a |
Collaborator
✅ [CI Build #acb222a] Build passed (Build macOS tests) ✅Pipeline on Agent |
Member
Author
|
Sorry, re-created as #24948 from a dev/* prefixed branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the workaround that disabled CoreCLR test variations on x64 to verify if dotnet/runtime#122563 has been fixed.
The original issue was a CoreCLR interpreter crash on x64 (stack overflow in
InterpreterStubRetI8). This PR re-enables the tests so CI can confirm whether the fix has landed in the runtime.