Fix HFA tests with interpreter #123818
Open
Fix HFA tests with interpreter #123818
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the HFA tests on arm64 were failing when the HFA size was not a multiple of the interpreter stack slot size and the HFAs were passed on stack. The problem is that the call stub generator joined two stack ranges into one copy not taking into account that the previous argument ended in the middle of the interpreter stack slot.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect stack-range merging in the interpreter call stub generator when an argument’s stack size doesn’t align to the interpreter stack slot size (notably impacting arm64 HFA args passed on stack), which was causing test failures.
Changes:
- Add an interpreter-slot-size alignment guard before merging adjacent stack argument copy ranges.
- Update the in-code comment to explain why certain stack ranges must not be merged.
davidwrighton
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the HFA tests on arm64 were failing when the HFA size was not a multiple of the interpreter stack slot size and the HFAs were passed on stack. The problem is that the call stub generator joined two stack ranges into one copy not taking into account that the previous argument ended in the middle of the interpreter stack slot.