[release/10.0] Revert forwarding activation signal#124879
Merged
steveisok merged 1 commit intorelease/10.0from Feb 26, 2026
Merged
[release/10.0] Revert forwarding activation signal#124879steveisok merged 1 commit intorelease/10.0from
steveisok merged 1 commit intorelease/10.0from
Conversation
Recent change to fix lookup of current thread in the activation handler also added forwarding of the activation signal to the previously registered handler. That part of the change was unrelated to the actual issue the change was fixing. It turned out that it breaks vsdbg that doesn't expect to get the SIGUSR1 used for the activation on macOS. This change reverts that part of the change to unblock vsdbg.
rbhanda
added
Servicing-approved
steveisok
approved these changes
Feb 26, 2026
Member
|
In order to make 10.0.4, this needs to be ported to the VMR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #124877 to release/10.0
/cc @janvorli
Customer Impact
A recent change that was backported to .NET 10.0.4 (#124308) was found to cause problems to vsdbg. That problem is caused by part of the change that was actually additional to the fix that that change made and that is not that important. That part of the change started to forward activation signal to handlers registered before the coreclr. This change just reverts that part.
Regression
#124308
Testing
Local testing
Risk
Low. It just stops forwarding the signal which was the behavior until the recent change.