Skip to content

[Draft] Fix for 125246#125747

Draft
dhartglassMSFT wants to merge 1 commit intodotnet:mainfrom
dhartglassMSFT:fix_for_125246
Draft

[Draft] Fix for 125246#125747
dhartglassMSFT wants to merge 1 commit intodotnet:mainfrom
dhartglassMSFT:fix_for_125246

Conversation

@dhartglassMSFT
Copy link
Contributor

Random-inline jit stress hits assert(varDsc->lvIsMultiRegRet); in lower.

Global morph replaces a multi-reg-ret return node with a local that doesn't have the bit marked, fix is to set that bit when Assertion copyprop does copy prop.

Also changed the text in some of the assertionprop logging to make the log messages unique.

fixes #125246

Copilot AI review requested due to automatic review settings March 18, 2026 21:22
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 18, 2026
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a CoreCLR JIT stress assertion on arm64 where a multi-reg struct return local can be substituted via assertion-driven copy propagation without carrying the required lvIsMultiRegRet marking, causing Lowering::ContainCheckRet to assert.

Changes:

  • Make optCopyAssertionProp propagate lvIsMultiRegRet from the original local to the substituted local.
  • Make several assertion-prop debug/verbose log headers unique to simplify log analysis.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Failure: Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests

2 participants