Skip to content

Stabilize ML-KEM APIs and remove Experimental attribute#125749

Open
vcsjones wants to merge 3 commits intodotnet:mainfrom
vcsjones:ml-kem-stabilize
Open

Stabilize ML-KEM APIs and remove Experimental attribute#125749
vcsjones wants to merge 3 commits intodotnet:mainfrom
vcsjones:ml-kem-stabilize

Conversation

@vcsjones
Copy link
Member

  1. The test data in MLKemTestData.cs already matches what is in the appendix of the RFC, so no changes were needed there.
  2. This stabilizes the SPKI / PKCS#8 / X.509 APIs for ML-KEM public and private keys and are no longer marked as experimental.

Closes #125738

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes the ML-KEM X.509 / SPKI / PKCS#8-related APIs by removing the Experimental (SYSLIB5006) annotations now that RFC 9935 has been published.

Changes:

  • Remove [Experimental] annotations from ML-KEM key import/export APIs (SPKI/PKCS#8/PEM) and related public surface area.
  • Remove [Experimental] annotations from ML-KEM X.509 key accessors (PublicKey and X509Certificate2, plus Microsoft.Bcl extension helpers).
  • Update an ML-KEM ASN.1 reference link from a draft to RFC 9935.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs Stabilizes ML-KEM certificate key accessors by removing Experimental attribute.
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/PublicKey.cs Stabilizes ML-KEM PublicKey constructor and ML-KEM public key accessor.
src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs Updates public reference surface to remove SYSLIB5006 annotations for ML-KEM APIs.
src/libraries/Microsoft.Bcl.Cryptography/src/System/Security/Cryptography/X509Certificates/X509CertificateKeyAccessors.cs Stabilizes ML-KEM extension accessors by removing Experimental attribute.
src/libraries/Common/src/System/Security/Cryptography/MLKem.cs Stabilizes ML-KEM import/export APIs by removing Experimental annotations and an unused using.
src/libraries/Common/src/System/Security/Cryptography/Asn1/MLKemPrivateKeyAsn.xml Updates spec link to RFC 9935 for ML-KEM private key ASN.1 definition.

You can also share your feedback on Copilot code review. Take the survey.

Copilot AI review requested due to automatic review settings March 18, 2026 22:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize ML-KEM X.509 certificates

2 participants