Add [RequiresUnsafe] to all extern and LibraryImport (CoreLib)

Directory.Build.props

@@ -285,6 +285,10 @@
     <WarningsNotAsErrors Condition="'$(OfficialBuild)' != 'true' OR '$(NuGetAuditWarnNotError)' == 'true'">$(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
     <!-- Warnings to always disable -->
     <NoWarn>$(NoWarn);CS8500;CS8969</NoWarn>
+
+    <!-- Temporarily suppress ILLink RequiresUnsafe call-site diagnostics for the entire repo. -->
+    <NoWarn>$(NoWarn);IL5000</NoWarn>
+
     <!-- Suppress "CS1591 - Missing XML comment for publicly visible type or member" compiler errors for private assemblies. -->
     <NoWarn Condition="'$(IsPrivateAssembly)' == 'true'">$(NoWarn);CS1591</NoWarn>
     <!-- Always pass portable to override arcade sdk which uses embedded for local builds -->

src/coreclr/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComActivator.cs

@@ -711,20 +711,23 @@ internal sealed class LicenseInteropProxy
         private Type? _targetRcwType;
 
         [UnsafeAccessor(UnsafeAccessorKind.Method)]
+        [RequiresUnsafe]
         private static extern void SetSavedLicenseKey(
             [UnsafeAccessorType(LicenseContextTypeName)] object licContext,
             Type type,
             string key);
 
         [UnconditionalSuppressMessage("Trimming", "IL2111", Justification = "Manually validated that the annotations are kept in sync.")]
         [UnsafeAccessor(UnsafeAccessorKind.StaticMethod)]
+        [RequiresUnsafe]
         private static extern object? CreateWithContext(
             [UnsafeAccessorType(LicenseManagerTypeName)] object? licManager,
             [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] Type type,
             [UnsafeAccessorType(LicenseContextTypeName)] object licContext
         );
 
         [UnsafeAccessor(UnsafeAccessorKind.StaticMethod)]
+        [RequiresUnsafe]
         private static extern bool ValidateAndRetrieveLicenseDetails(
             [UnsafeAccessorType(LicenseInteropHelperTypeName)] object? licInteropHelper,
             [UnsafeAccessorType(LicenseContextTypeName)] object? licContext,
@@ -733,6 +736,7 @@ private static extern bool ValidateAndRetrieveLicenseDetails(
             out string? licenseKey);
 
         [UnsafeAccessor(UnsafeAccessorKind.StaticMethod)]
+        [RequiresUnsafe]
         [return: UnsafeAccessorType(LicenseContextTypeName)]
         private static extern object? GetCurrentContextInfo(
             [UnsafeAccessorType(LicenseInteropHelperTypeName)] object? licInteropHelper,
@@ -741,23 +745,27 @@ private static extern bool ValidateAndRetrieveLicenseDetails(
             out string? key);
 
         [UnsafeAccessor(UnsafeAccessorKind.StaticMethod)]
+        [RequiresUnsafe]
         [return: UnsafeAccessorType(CLRLicenseContextTypeName)]
         private static extern object CreateDesignContext(
             [UnsafeAccessorType(CLRLicenseContextTypeName)] object? context,
             Type type);
 
         [UnsafeAccessor(UnsafeAccessorKind.StaticMethod)]
+        [RequiresUnsafe]
         [return: UnsafeAccessorType(CLRLicenseContextTypeName)]
         private static extern object CreateRuntimeContext(
             [UnsafeAccessorType(CLRLicenseContextTypeName)] object? context,
             Type type,
             string? key);
 
         [UnsafeAccessor(UnsafeAccessorKind.Constructor)]
+        [RequiresUnsafe]
         [return:UnsafeAccessorType(LicInfoHelperLicenseContextTypeName)]
         private static extern object CreateLicInfoHelperLicenseContext();
 
         [UnsafeAccessor(UnsafeAccessorKind.Method)]
+        [RequiresUnsafe]
         private static extern bool Contains(
             [UnsafeAccessorType(LicInfoHelperLicenseContextTypeName)] object? licInfoHelperContext,
             string assemblyName);

src/coreclr/System.Private.CoreLib/src/Internal/VersionResilientHashCode.CoreCLR.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Reflection.Metadata;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
@@ -14,6 +15,7 @@ namespace Internal
     internal static partial class VersionResilientHashCode
     {
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "VersionResilientHashCode_TypeHashCode")]
+        [RequiresUnsafe]
         private static partial int TypeHashCode(QCallTypeHandle typeHandle);
 
         public static int TypeHashCode(RuntimeType type)

src/coreclr/System.Private.CoreLib/src/System/AppContext.CoreCLR.cs

@@ -56,6 +56,7 @@ internal static void SetFirstChanceExceptionHandler()
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "AppContext_SetFirstChanceExceptionHandler")]
         [SuppressGCTransition]
+        [RequiresUnsafe]
         private static partial void SetFirstChanceExceptionHandlerInternal();
     }
 }

src/coreclr/System.Private.CoreLib/src/System/ArgIterator.cs

@@ -41,6 +41,7 @@ public ArgIterator(RuntimeArgumentHandle arglist)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ArgIterator_Init")]
+        [RequiresUnsafe]
         private static partial void Init(ArgIterator* thisPtr, IntPtr cookie);
 
         // create an arg iterator that points just past 'firstArg'.
@@ -57,6 +58,7 @@ public ArgIterator(RuntimeArgumentHandle arglist, void* ptr)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ArgIterator_Init2")]
+        [RequiresUnsafe]
         private static partial void Init(ArgIterator* thisPtr, IntPtr cookie, void* ptr);
 
         // Fetch an argument as a typed referece, advance the iterator.
@@ -83,6 +85,7 @@ public TypedReference GetNextArg()
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ArgIterator_GetNextArg")]
+        [RequiresUnsafe]
         private static partial void GetNextArg(ArgIterator* thisPtr, TypedReference* pResult);
 
         // Alternate version of GetNextArg() intended primarily for IJW code
@@ -118,6 +121,7 @@ public TypedReference GetNextArg(RuntimeTypeHandle rth)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ArgIterator_GetNextArg2")]
+        [RequiresUnsafe]
         private static partial void GetNextArg(ArgIterator* thisPtr, QCallTypeHandle rth, TypedReference* pResult);
 
         // This method should invalidate the iterator (va_end). It is not supported yet.
@@ -143,6 +147,7 @@ public RuntimeTypeHandle GetNextArgType()
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ArgIterator_GetNextArgType")]
+        [RequiresUnsafe]
         private static partial IntPtr GetNextArgType(ArgIterator* thisPtr);
 
         public override int GetHashCode()

src/coreclr/System.Private.CoreLib/src/System/ComAwareWeakReference.CoreCLR.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
@@ -10,6 +11,7 @@ namespace System
     internal sealed partial class ComAwareWeakReference
     {
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ComWeakRefToObject")]
+        [RequiresUnsafe]
         private static partial void ComWeakRefToObject(IntPtr pComWeakRef, ObjectHandleOnStack retRcw);
 
         internal static object? ComWeakRefToObject(IntPtr pComWeakRef, object? context)
@@ -39,6 +41,7 @@ internal static bool PossiblyComObject(object target)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ObjectToComWeakRef")]
+        [RequiresUnsafe]
         private static partial IntPtr ObjectToComWeakRef(ObjectHandleOnStack retRcw);
 
         internal static nint ObjectToComWeakRef(object target, out object? context)

src/coreclr/System.Private.CoreLib/src/System/Delegate.CoreCLR.cs

@@ -480,6 +480,7 @@ private void DelegateConstruct(object target, IntPtr method)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "Delegate_Construct")]
+        [RequiresUnsafe]
         private static partial void Construct(ObjectHandleOnStack _this, ObjectHandleOnStack target, IntPtr method);
 
         [MethodImpl(MethodImplOptions.InternalCall)]
@@ -525,6 +526,7 @@ internal IRuntimeMethodInfo FindMethodHandle()
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "Delegate_FindMethodHandle")]
+        [RequiresUnsafe]
         private static partial void FindMethodHandle(ObjectHandleOnStack d, ObjectHandleOnStack retMethodInfo);
 
         private static bool InternalEqualMethodHandles(Delegate left, Delegate right)
@@ -542,6 +544,7 @@ internal static IntPtr AdjustTarget(object target, IntPtr methodPtr)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "Delegate_AdjustTarget")]
+        [RequiresUnsafe]
         private static partial IntPtr AdjustTarget(ObjectHandleOnStack target, IntPtr methodPtr);
 
         internal void InitializeVirtualCallStub(IntPtr methodPtr)
@@ -551,6 +554,7 @@ internal void InitializeVirtualCallStub(IntPtr methodPtr)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "Delegate_InitializeVirtualCallStub")]
+        [RequiresUnsafe]
         private static partial void InitializeVirtualCallStub(ObjectHandleOnStack d, IntPtr methodPtr);
 
         internal virtual object? GetTarget()

src/coreclr/System.Private.CoreLib/src/System/Diagnostics/Debugger.cs

@@ -4,6 +4,7 @@
 // The Debugger class is a part of the System.Diagnostics package
 // and is used for communicating with a debugger.
 
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
@@ -12,6 +13,7 @@ namespace System.Diagnostics
     public static partial class Debugger
     {
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "DebugDebugger_Break")]
+        [RequiresUnsafe]
         private static partial void BreakInternal();
 
         // Break causes a breakpoint to be signalled to an attached debugger.  If no debugger
@@ -63,6 +65,7 @@ static void NotifyOfCrossThreadDependencySlow()
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "DebugDebugger_IsManagedDebuggerAttached")]
         [SuppressGCTransition]
+        [RequiresUnsafe]
         private static partial int IsManagedDebuggerAttached();
 
         // Posts a message for the attached debugger.  If there is no
@@ -78,12 +81,14 @@ static void NotifyOfCrossThreadDependencySlow()
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "DebugDebugger_IsLoggingHelper")]
         [SuppressGCTransition]
+        [RequiresUnsafe]
         private static partial int IsLoggingInternal();
 
         // Posts a custom notification for the attached debugger.  If there is no
         // debugger attached, has no effect.  The debugger may or may not
         // report the notification depending on its settings.
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "DebugDebugger_CustomNotification")]
+        [RequiresUnsafe]
         private static partial void CustomNotification(ObjectHandleOnStack data);
 
         // implementation of CORINFO_HELP_USER_BREAKPOINT

src/coreclr/System.Private.CoreLib/src/System/Diagnostics/StackFrame.CoreCLR.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
@@ -57,6 +58,7 @@ private void BuildStackFrame(int skipFrames, bool needFileInfo)
 #pragma warning restore IDE0060
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "StackFrame_GetMethodDescFromNativeIP")]
+        [RequiresUnsafe]
         private static partial RuntimeMethodHandleInternal GetMethodDescFromNativeIP(IntPtr ip);
 
         /// <summary>

src/coreclr/System.Private.CoreLib/src/System/Diagnostics/StackFrameHelper.cs

@@ -40,10 +40,12 @@ internal sealed class StackFrameHelper
 #pragma warning restore 414
 
         [UnsafeAccessor(UnsafeAccessorKind.Constructor)]
+        [RequiresUnsafe]
         [return: UnsafeAccessorType("System.Diagnostics.StackTraceSymbols, System.Diagnostics.StackTrace, Version=4.0.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a")]
         private static extern object CreateStackTraceSymbols();
 
         [UnsafeAccessor(UnsafeAccessorKind.Method)]
+        [RequiresUnsafe]
         private static extern void GetSourceLineInfo(
             [UnsafeAccessorType("System.Diagnostics.StackTraceSymbols, System.Diagnostics.StackTrace, Version=4.0.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a")] object target,
             Assembly? assembly, string assemblyPath, IntPtr loadedPeAddress,

src/coreclr/System.Private.CoreLib/src/System/Enum.CoreCLR.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Numerics;
 using System.Reflection;
 using System.Runtime.CompilerServices;
@@ -12,6 +13,7 @@ namespace System
     public abstract partial class Enum
     {
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "Enum_GetValuesAndNames")]
+        [RequiresUnsafe]
         private static partial void GetEnumValuesAndNames(QCallTypeHandle enumType, ObjectHandleOnStack values, ObjectHandleOnStack names, Interop.BOOL getNames);
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]

src/coreclr/System.Private.CoreLib/src/System/Environment.CoreCLR.cs

@@ -21,6 +21,7 @@ public static extern int CurrentManagedThreadId
         // Terminates this process with the given exit code.
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "Environment_Exit")]
         [DoesNotReturn]
+        [RequiresUnsafe]
         private static partial void _Exit(int exitCode);
 
         [DoesNotReturn]
@@ -105,6 +106,7 @@ private static unsafe string[] InitializeCommandLineArgs(char* exePath, int argc
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "Environment_GetProcessorCount")]
+        [RequiresUnsafe]
         internal static partial int GetProcessorCount();
 
         [UnmanagedCallersOnly]

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs

@@ -56,6 +56,7 @@ private IDictionary CreateDataContainer()
         private static extern bool IsImmutableAgileException(Exception e);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ExceptionNative_GetMethodFromStackTrace")]
+        [RequiresUnsafe]
         private static partial void GetMethodFromStackTrace(ObjectHandleOnStack stackTrace, ObjectHandleOnStack method);
 
         private MethodBase? GetExceptionMethodFromStackTrace()
@@ -215,6 +216,7 @@ internal static string GetMessageFromNativeResources(ExceptionMessageKind kind)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ExceptionNative_GetMessageFromNativeResources")]
+        [RequiresUnsafe]
         private static partial void GetMessageFromNativeResources(ExceptionMessageKind kind, StringHandleOnStack retMesg);
 
         internal readonly struct DispatchState
@@ -238,6 +240,7 @@ public DispatchState(
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ExceptionNative_GetFrozenStackTrace")]
+        [RequiresUnsafe]
         private static partial void GetFrozenStackTrace(ObjectHandleOnStack exception, ObjectHandleOnStack stackTrace);
 
         internal DispatchState CaptureDispatchState()