Remove net472 containers by YuliiaKovalova · Pull Request #53547 · dotnet/sdk

YuliiaKovalova · 2026-03-20T15:25:13Z

Summary

Remove the net472 target from the Containers SDK (Microsoft.NET.Build.Containers), keeping only the .NET Core ($(SdkTargetFramework)) target.

The net472 build existed to support Visual Studio's Full-Framework MSBuild (MSBuildRuntimeType == Full). Now that VS uses .NET Runtime with HostObject support for container operations, the net472 target and all this infrastructure is no longer needed.

Fixes

dotnet/msbuild#11333

…ainers

YuliiaKovalova · 2026-03-23T17:20:50Z

/azp run

azure-pipelines · 2026-03-23T17:21:00Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR removes the net472 target and associated packaging/test/layout infrastructure from the Containers SDK (Microsoft.NET.Build.Containers), aligning with the move away from Full Framework MSBuild for VS container operations.

Changes:

Drop multi-targeting ($(SdkTargetFramework);net472) for Microsoft.NET.Build.Containers and related integration tests, removing net472-only source/test shims.
Remove net472 task publishing/packaging outputs (layout + nupkg content) and update package content expectations accordingly.
Update the shipped .props to always point at the .NET (net10.0) task implementation.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/UnitTests.proj	Stops including Containers integration tests in the `TestFullMSBuild`/`net472` run.
test/Microsoft.NET.Build.Containers.IntegrationTests/PackageTests.cs	Updates dependency and nupkg content assertions to remove `tasks/net472` expectations.
test/Microsoft.NET.Build.Containers.IntegrationTests/Microsoft.NET.Build.Containers.IntegrationTests.csproj	Removes `net472` target and related conditional compilation setup.
test/Microsoft.NET.Build.Containers.IntegrationTests/FullFramework/CreateNewImageToolTaskTests.cs	Deletes Full Framework–specific tests for the removed ToolTask-based implementation.
src/Layout/redist/targets/GenerateLayout.targets	Removes publishing of `net472` task assets into the redist layout.
src/Layout/redist/targets/Crossgen.targets	Updates comment to reflect removal of `net472` components.
src/Containers/packaging/package.csproj	Removes `net472` packaging path and dependency harvesting for `net472` tasks.
src/Containers/packaging/build/Microsoft.NET.Build.Containers.props	Removes MSBuild runtime-based TFM selection; uses only `net10.0` tasks and updates `UsingTask` declarations.
src/Containers/Microsoft.NET.Build.Containers/net472Definitions.cs	Deletes `net472`-only polyfills (`IsExternalInit`, `NotNullWhenAttribute`).
src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImageToolTask.cs	Deletes the `net472` ToolTask-based shim implementation.
src/Containers/Microsoft.NET.Build.Containers/Tasks/ComputeDotnetBaseImageAndTag.cs	Removes now-unused `NETFRAMEWORK`-only `using` directives.
src/Containers/Microsoft.NET.Build.Containers/PublicAPI/net472/PublicAPI.Unshipped.txt	Removes `net472` public API baseline.
src/Containers/Microsoft.NET.Build.Containers/PublicAPI/net472/PublicAPI.Shipped.txt	Removes `net472` public API baseline header.
src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj	Removes `net472` TFM and all `net472`-specific compile/package reference conditionals.
src/Containers/Microsoft.NET.Build.Containers/ContainerHelpers.cs	Removes `NETFRAMEWORK`/`NET` conditional usings now that `net472` is gone.

baronfel · 2026-03-24T04:01:43Z

This looks correct, however anyone still using the Microsoft.Net.Build.Containers NuGet package and using an older version of VS will be broken if they upgrade. We need to stop publishing the package now that it's baked into the SDK too.

YuliiaKovalova · 2026-03-24T16:07:33Z

This looks correct, however anyone still using the Microsoft.Net.Build.Containers NuGet package and using an older version of VS will be broken if they upgrade. We need to stop publishing the package now that it's baked into the SDK too.

@marcpopMSFT & @mmitche could you please check this comment? Do you have any concerns regarding removing this package from publishing?

mmitche · 2026-03-24T17:08:38Z

This looks correct, however anyone still using the Microsoft.Net.Build.Containers NuGet package and using an older version of VS will be broken if they upgrade. We need to stop publishing the package now that it's baked into the SDK too.

@marcpopMSFT & @mmitche could you please check this comment? Do you have any concerns regarding removing this package from publishing?

Only concern is that it shows up as a package ref somewhere we don't expect, but we should find that in testing. Mark the package as non-shipping and I think that should about do it.

YuliiaKovalova · 2026-03-25T09:57:35Z

This looks correct, however anyone still using the Microsoft.Net.Build.Containers NuGet package and using an older version of VS will be broken if they upgrade. We need to stop publishing the package now that it's baked into the SDK too.

@marcpopMSFT & @mmitche could you please check this comment? Do you have any concerns regarding removing this package from publishing?

Only concern is that it shows up as a package ref somewhere we don't expect, but we should find that in testing. Mark the package as non-shipping and I think that should about do it.

Cool, thanks!
Done

baronfel · 2026-03-25T21:45:22Z

        <IsPackable>true</IsPackable>
-        <IsShipping>true</IsShipping>
+        <IsShipping>false</IsShipping>
        <IsShippingPackage>true</IsShippingPackage>


@mmitche what's the difference/meaning of IsShipping vs IsShippingPackage? Are both needed?

IsShipping is broader than IsShippingPackage. IsShipping are used in projects where some assets produced are shipping while others are not: https://github.com/dotnet/arcade/blob/main/Documentation/ArcadeSdk.md#isshipping-isshippingassembly-isshippingpackage-isshippingvsix-bool

I would set IsShipping == false

…ainers

Removed Containers from RemainingFiles to prevent crossgenning of containerized DLLs.

Delete netframeworkDefinitions.cs which contained net472-only polyfills (IsExternalInit, NotNullWhenAttribute). With the net472 target removed, these polyfills are no longer needed and the NotNullWhenAttribute in the Microsoft.NET.Build.Containers namespace was shadowing the real System.Diagnostics.CodeAnalysis.NotNullWhenAttribute, causing CS8767 in the test project (via InternalsVisibleTo). Also restore the [NotNullWhen(true)] attribute on MockEnvironmentProvider to match the IEnvironmentProvider interface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ainers

…ub.com/dotnet/sdk into dev/ykovalova/remove_net472_containers

YuliiaKovalova · 2026-04-08T17:20:19Z

hi @lbussell ,
Could you please review the changes?

…ainers

YuliiaKovalova · 2026-04-08T19:06:24Z

hm , after pulling changes from the target branch the tests fail with
》C:\Program Files\Microsoft Visual Studio\18\Insiders\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(1259,5): error MSB3644: The reference assemblies for .NETFramework,Version=v4.6.9 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [C:\h\w\AA3A097C\t\dotnetSdkTests\hepu34ny.vpu\MissingRefere---C53218B1\MissingReferenceAssemblies\MissingReferenceAssemblies.csproj]

https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-53547-merge-b36b34842dd1493ea8/Microsoft.NET.Build.Tests.dll.4/3/console.b0eae202.log?helixlogtype=result&skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2026-04-08T19%3A03%3A13Z&ske=2026-04-08T20%3A03%3A13Z&sks=b&skv=2026-02-06&sv=2026-02-06&se=2026-04-08T20%3A03%3A13Z&sr=b&sp=rl&sig=CbfG9rtbvtmyEysehbVKmhPJ5ybf3254LrHiDuVGres%3D

…ainers

…shipping - Remove ToolExe, ToolPath properties from CreateNewImage (ToolTask was deleted) - Remove ContainerizeDirectory property (only used by ToolTask) - Remove DotNetHost PropertyGroup from targets (only used for ToolTask) - Remove ContainerizeFolder/ContainerizeFolderName from props (no longer referenced) - Remove IsShippingPackage=true (IsShipping=false is sufficient) - Fix CopyNupkgToCustomFolder path: Shipping -> NonShipping - Update PublicAPI.Unshipped.txt accordingly Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Dependency flow had bumped versions on the PR branch independently, causing test failures due to version misalignment with the base branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This reverts commit de578af.

…ainers

YuliiaKovalova · 2026-04-22T09:38:25Z

HI @DonnaChen888 ,

The reported failures aren't related to my changes, I see the same in https://github.com/dotnet/sdk/runs/72391515947

could you please force-merge it? I have an approval from containers maintainer.

DonnaChen888 · 2026-04-22T09:47:28Z

HI @DonnaChen888 ,

The reported failures aren't related to my changes, I see the same in https://github.com/dotnet/sdk/runs/72391515947

could you please force-merge it? I have an approval from containers maintainer.

Hi @marcpopMSFT, @dsplaisted, could you please take a look?

remove net472 containers

1909504

github-actions Bot added the Area-Containers Related to dotnet SDK containers functionality label Mar 20, 2026

YuliiaKovalova changed the base branch from main to release/10.0.3xx March 23, 2026 12:35

YuliiaKovalova and others added 4 commits March 23, 2026 13:35

Merge branch 'release/10.0.3xx' into dev/ykovalova/remove_net472_cont…

bfb8e06

…ainers

clenup container tests

0de9a95

more cleanup

ef3e8a0

more cleanup

fd8270e

YuliiaKovalova changed the title ~~remove net472 containers~~ Remove net472 containers Mar 23, 2026

YuliiaKovalova marked this pull request as ready for review March 23, 2026 17:14

YuliiaKovalova requested a review from a team as a code owner March 23, 2026 17:14

Copilot AI review requested due to automatic review settings March 23, 2026 17:14

Copilot started reviewing on behalf of YuliiaKovalova March 23, 2026 17:15 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread src/Containers/packaging/package.csproj Outdated

marcpopMSFT requested a review from lbussell March 24, 2026 20:22

set IsShipping to false

9f6d274

baronfel reviewed Mar 25, 2026

View reviewed changes

YuliiaKovalova and others added 3 commits March 26, 2026 07:33

Merge branch 'release/10.0.3xx' into dev/ykovalova/remove_net472_cont…

b1b80a4

…ainers

fix after merge

b5cbcd3

Exclude Containers from crossgenning process

a71bb60

Removed Containers from RemainingFiles to prevent crossgenning of containerized DLLs.

build-analysis Bot mentioned this pull request Mar 26, 2026

Template engine tests hitting known parallelism issue in GetVisualStudioInstances #44878

Open

YuliiaKovalova and others added 3 commits March 26, 2026 11:03

more changes after merge

9a60c10

fix after merge

5ad1d85

build-analysis Bot mentioned this pull request Mar 26, 2026

dotnet-watch tests failing #40006

Open

YuliiaKovalova and others added 3 commits March 27, 2026 11:44

Merge branch 'release/10.0.3xx' into dev/ykovalova/remove_net472_cont…

f935e57

…ainers

fix encoding

f64f27a

Merge branch 'dev/ykovalova/remove_net472_containers' of https://gith…

c7ad49a

…ub.com/dotnet/sdk into dev/ykovalova/remove_net472_containers

YuliiaKovalova requested a review from baronfel March 31, 2026 10:44

Merge branch 'release/10.0.3xx' into dev/ykovalova/remove_net472_cont…

afa1693

…ainers

mthalman reviewed Apr 8, 2026

View reviewed changes

Comment thread src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs

YuliiaKovalova and others added 3 commits April 9, 2026 12:54

Merge branch 'release/10.0.3xx' into dev/ykovalova/remove_net472_cont…

4c71fb4

…ainers

Reset dependency versions to match release/10.0.3xx

de578af

Dependency flow had bumped versions on the PR branch independently, causing test failures due to version misalignment with the base branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

mthalman approved these changes Apr 9, 2026

View reviewed changes

YuliiaKovalova and others added 3 commits April 9, 2026 15:35

Revert "Reset dependency versions to match release/10.0.3xx"

3c7588b

This reverts commit de578af.

Merge branch 'release/10.0.3xx' into dev/ykovalova/remove_net472_cont…

64a4332

…ainers

Merge branch 'release/10.0.3xx' into dev/ykovalova/remove_net472_cont…

ff1da9b

…ainers

build-analysis Bot mentioned this pull request Apr 22, 2026

[Known Build Error] Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.dll crash #54014

Closed

dsplaisted enabled auto-merge April 22, 2026 15:04

Conversation

YuliiaKovalova commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Fixes

Uh oh!

YuliiaKovalova commented Mar 23, 2026

Uh oh!

azure-pipelines Bot commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

baronfel commented Mar 24, 2026

Uh oh!

YuliiaKovalova commented Mar 24, 2026

Uh oh!

mmitche commented Mar 24, 2026

Uh oh!

YuliiaKovalova commented Mar 25, 2026

Uh oh!

baronfel Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

mmitche Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

YuliiaKovalova commented Apr 8, 2026

Uh oh!

YuliiaKovalova commented Apr 8, 2026

Uh oh!

Uh oh!

YuliiaKovalova commented Apr 22, 2026

Uh oh!

DonnaChen888 commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

YuliiaKovalova commented Mar 20, 2026 •

edited

Loading