Skip to content

TextStore: initialize callback state before RegisterTextStore #11457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
etvorun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

TextStore: initialize callback state before RegisterTextStore #11457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/TextStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,15 +1611,21 @@ internal void OnAttach()
{
_netCharCount = this.TextContainer.IMECharCount;

// RegisterTextStore can synchronously trigger TSF callbacks (for example ITfTextEditSink.OnEndEdit).
// This is observable with WeChat Input Method, which is a third-party TSF text service
// (a TIP/IME engine, not merely a keyboard layout). Those callbacks dereference
// _textservicesproperty, so initialize it before registering with TSF.
_textservicesproperty = new TextServicesProperty(this);

// WeChat's TIP can issue attach/focus-time edits while registration is still in progress.
// Hook text change notifications before registration so those edits update _netCharCount.
this.TextContainer.Change += new TextContainerChangeEventHandler(OnTextContainerChange);

// keep _textservicesHost because we may not be in Dispatcher when GC Finalizer calls OnDetach().
_textservicesHost = TextServicesHost.Current;

_textservicesHost.RegisterTextStore(this);

this.TextContainer.Change += new TextContainerChangeEventHandler(OnTextContainerChange);

_textservicesproperty = new TextServicesProperty(this);

if (IMECompositionTracer.IsEnabled)
{
IMECompositionTracer.ConfigureTracing(this);
Expand Down