-
-
Notifications
You must be signed in to change notification settings - Fork 375
doc(Table): update TableToolbarTemplate parameter comments #7666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExpose new toolbar templates on SelectTable so consumers can inject custom content before and after the default table toolbar buttons, and forward these parameters directly to the underlying Table component. Sequence diagram for rendering SelectTable toolbar templatessequenceDiagram
actor User
participant Page
participant SelectTable
participant Table
User->>Page: Trigger render
Page->>SelectTable: Render SelectTable
SelectTable->>SelectTable: Set TableToolbarBeforeTemplate
SelectTable->>SelectTable: Set TableToolbarTemplate
SelectTable->>Table: Render Table with TableToolbarBeforeTemplate and TableToolbarTemplate
Table-->>User: Display table with custom toolbar content
Class diagram for SelectTable with new toolbar templatesclassDiagram
class SelectTable {
+string MultiSelectedItemMaxWidth
+RenderFragment TableToolbarBeforeTemplate
+RenderFragment TableToolbarTemplate
}
class Table {
+bool IsPagination
+IEnumerable PageItemsSource
+bool ShowGotoNavigator
+int MaxPageLinkCount
+Func OnClickRowCallback
+Func OnQueryAsync
+bool IsMultipleSelect
+IEnumerable SelectedRows
+RenderFragment TableToolbarBeforeTemplate
+RenderFragment TableToolbarTemplate
+bool ShowEmpty
+RenderFragment EmptyTemplate
}
SelectTable --> Table : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The XML documentation for
TableToolbarBeforeTemplateandTableToolbarTemplateboth use the same high-level English summary ("Table Toolbar Button Template"); consider clarifying in the first<para lang="en">for each that one is the "before default buttons" template and the other is the "after default buttons" template to make their roles immediately clear in IntelliSense. - Both the Chinese and English descriptions currently say "toolbar left button template" for
TableToolbarTemplate, even though it renders after the default buttons; updating this wording to match the actual position (and to distinguish it fromTableToolbarBeforeTemplate) would reduce confusion for consumers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The XML documentation for `TableToolbarBeforeTemplate` and `TableToolbarTemplate` both use the same high-level English summary ("Table Toolbar Button Template"); consider clarifying in the first `<para lang="en">` for each that one is the "before default buttons" template and the other is the "after default buttons" template to make their roles immediately clear in IntelliSense.
- Both the Chinese and English descriptions currently say "toolbar left button template" for `TableToolbarTemplate`, even though it renders after the default buttons; updating this wording to match the actual position (and to distinguish it from `TableToolbarBeforeTemplate`) would reduce confusion for consumers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7666 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 33196 33196
Branches 4605 4605
=========================================
Hits 33196 33196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds support for injecting custom toolbar content into the SelectTable’s internal Table, addressing the request to place custom controls (e.g., buttons) in the dropdown table UI.
Changes:
- Added
TableToolbarBeforeTemplateandTableToolbarTemplateparameters toSelectTable<TItem>. - Forwarded the new toolbar template parameters to the inner
Tablecomponent. - Updated the package version in
BootstrapBlazor.csproj.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/BootstrapBlazor/Components/Select/SelectTable.razor.cs | Introduces new SelectTable parameters for table toolbar templates. |
| src/BootstrapBlazor/Components/Select/SelectTable.razor | Passes the new toolbar templates through to the nested Table. |
| src/BootstrapBlazor/BootstrapBlazor.csproj | Changes the package version from beta to stable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Link issues
fixes #7667
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: