Merged
Conversation
slusarz
force-pushed
the
add-max_test_connections
branch
from
a9139e3 to
f72f085
Compare
Contributor
|
Seems a bit unnecessary. I think a hardcoded limit would work just as well.. |
Contributor
Author
|
Heh. This was a jules flagged issue, and it suggested a hardcoded value, and then i spent 30 minutes and manually changed to a CLI value. So maybe I will go back and find the original MR suggestion. |
Enforce a hardcoded limit of 100 connections in the test parser to prevent unbounded memory allocation in test files. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
slusarz
force-pushed
the
add-max_test_connections
branch
from
f72f085 to
7c7b418
Compare
Contributor
Author
|
Reverted to hardcoding the limit. |
sirainen
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_conf_default() is added here as an additional commit, or else it would cause merge conflicts later if these were set separately (since the previous commit adds a default value).