[#2399] Added Behat attribute set to Rector configuration.#2416
[#2399] Added Behat attribute set to Rector configuration.#2416AlexSkrypnyk merged 4 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
WalkthroughUpdates the Rector configuration by appending Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
==========================================
- Coverage 79.42% 78.93% -0.49%
==========================================
Files 126 119 -7
Lines 6730 6571 -159
Branches 44 0 -44
==========================================
- Hits 5345 5187 -158
+ Misses 1385 1384 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Closes #2399
Summary
Added
->withAttributesSets(behat: TRUE)to the Rector configuration inrector.phpso that Behat annotations are automatically converted to PHP 8 attributes during static analysis runs. Updated test fixture snapshots to reflect the new configuration line being present in the baseline and absent in scenarios where Behat is not installed.Changes
Rector configuration (
rector.php)->withAttributesSets(behat: TRUE)call after->withPhpSets(php84: TRUE)with a descriptive comment explaining its purpose.Test fixture snapshots (
.vortex/installer/tests/Fixtures/handler_process/)_baseline/rector.php— updated snapshot to include the newwithAttributesSets(behat: TRUE)line.tools_groups_no_be_tests/rector.php— updated diff snapshot: line number offsets corrected and the Behat attribute line is shown as removed (Behat not present in this scenario).tools_groups_no_be_tests_circleci/rector.php— same corrections astools_groups_no_be_tests.tools_no_behat/rector.php— new fixture file showing the Behat attribute line removed when Behat is not selected.tools_no_behat_circleci/rector.php— new fixture file mirroringtools_no_behatfor the CircleCI variant.tools_no_phpunit/rector.php— corrected diff line number offsets (no content change, offsets shifted due to the new line).tools_no_phpunit_circleci/rector.php— same offset correction astools_no_phpunit.Before / After
Summary by CodeRabbit