Skip to content

[#2173] Added per-channel branch filtering for notifications. Part 2.#2430

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/2173-update-docs
Mar 26, 2026
Merged

[#2173] Added per-channel branch filtering for notifications. Part 2.#2430
AlexSkrypnyk merged 1 commit intomainfrom
feature/2173-update-docs

Conversation

@AlexSkrypnyk
Copy link
Copy Markdown
Member

@AlexSkrypnyk AlexSkrypnyk commented Mar 26, 2026

Related #2173

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated New Relic notification channel documentation to reflect expanded branch filter defaults: notifications now trigger for main, master, and develop branches.
  • Tests

    • Updated unit tests to validate the new branch filter configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c4b475bf-2645-47bd-a390-ddf9ca5de826

📥 Commits

Reviewing files that changed from the base of the PR and between 9a00092 and 4937ee4.

📒 Files selected for processing (4)
  • .vortex/docs/content/deployment/notifications.mdx
  • .vortex/docs/content/development/variables.mdx
  • .vortex/tests/bats/unit/notify-newrelic.bats
  • scripts/vortex/notify-newrelic.sh

Walkthrough

This PR updates the default branch allowlist for New Relic notifications from main,master to main,master,develop, expanding which branches trigger notifications by default. The change is propagated across documentation, the notification script, and corresponding tests.

Changes

Cohort / File(s) Summary
Documentation
.vortex/docs/content/deployment/notifications.mdx, .vortex/docs/content/development/variables.mdx
Updated documented default value for VORTEX_NOTIFY_NEWRELIC_BRANCHES to include develop branch in the allowlist.
Implementation
scripts/vortex/notify-newrelic.sh
Updated script default for VORTEX_NOTIFY_NEWRELIC_BRANCHES variable from main,master to main,master,develop.
Tests
.vortex/tests/bats/unit/notify-newrelic.bats
Updated unit test expectations and inline documentation to reflect the new default; test now validates branch filtering behavior with updated branch reference values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • PR #2429: Directly modifies VORTEX_NOTIFY_NEWRELIC_BRANCHES usage and defaults in the same script and documentation files.
  • PR #2175: Updates the notify-newrelic script and associated tests, adding an enablement guard to related functionality.
  • PR #2095: Modifies New Relic notification handling and branch variable reconciliation in notify-newrelic code and tests.

Poem

🐰 A develop branch joins the fold,
Where main and master once stood bold.
Now three shall notify with cheer,
As deployments spread both far and near! 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references issue #2173 and describes adding per-channel branch filtering for notifications as Part 2, but the actual changes only update the default value of VORTEX_NOTIFY_NEWRELIC_BRANCHES from 'main,master' to 'main,master,develop' across documentation and tests—a straightforward default value update rather than adding new per-channel filtering functionality. Revise the title to accurately reflect the actual changes, such as: '[#2173] Updated default branch filter for New Relic notifications' or similar, to clearly communicate that this PR updates existing defaults rather than implementing new filtering features.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/2173-update-docs

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk
Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (189/189)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.24%. Comparing base (9a00092) to head (4937ee4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2430      +/-   ##
==========================================
- Coverage   79.71%   79.24%   -0.47%     
==========================================
  Files         127      120       -7     
  Lines        6831     6672     -159     
  Branches       44        0      -44     
==========================================
- Hits         5445     5287     -158     
+ Misses       1386     1385       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk merged commit 39ef060 into main Mar 26, 2026
30 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/2173-update-docs branch March 26, 2026 10:19
@github-project-automation github-project-automation bot moved this from BACKLOG to Release queue in Vortex Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant