Fix S3 copy/move operations to include SSE-C extra args using ALLOWED_COPY_ARGS#553
Open
divcodes1121 wants to merge 2 commits intodrivendataorg:masterfrom
Open
Fix S3 copy/move operations to include SSE-C extra args using ALLOWED_COPY_ARGS#553divcodes1121 wants to merge 2 commits intodrivendataorg:masterfrom
divcodes1121 wants to merge 2 commits intodrivendataorg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Added support for passing SSE-C related arguments during S3 copy/move operations.
Changes
boto3_cp_extra_argsusingTransferManager.ALLOWED_COPY_ARGS_move_fileto correctly include copy-specific argumentscopy_fromto preserve existing behaviorWhy
Previously, SSE-C parameters like
CopySourceSSECustomerKeywere not passed during copy/move operations.Testing
Closes #500
Contributor checklist:
CONTRIBUTING.mdCloses #issueappears in the PR summary (e.g.,Closes #123).HISTORY.mdwith the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.