Skip to content

Fix S3 copy/move operations to include SSE-C extra args using ALLOWED_COPY_ARGS#553

Open
divcodes1121 wants to merge 2 commits intodrivendataorg:masterfrom
divcodes1121:master
Open

Fix S3 copy/move operations to include SSE-C extra args using ALLOWED_COPY_ARGS#553
divcodes1121 wants to merge 2 commits intodrivendataorg:masterfrom
divcodes1121:master

Conversation

@divcodes1121
Copy link

@divcodes1121 divcodes1121 commented Mar 19, 2026

Fix

Added support for passing SSE-C related arguments during S3 copy/move operations.

Changes

  • Introduced boto3_cp_extra_args using TransferManager.ALLOWED_COPY_ARGS
  • Updated _move_file to correctly include copy-specific arguments
  • Merged upload and copy args for copy_from to preserve existing behavior

Why

Previously, SSE-C parameters like CopySourceSSECustomerKey were not passed during copy/move operations.

Testing

  • Ran full test suite: all tests passed

Closes #500


Contributor checklist:

  • I have read and understood CONTRIBUTING.md
  • Confirmed an issue exists for the PR, and the text Closes #issue appears in the PR summary (e.g., Closes #123).
  • Confirmed PR is rebased onto the latest base
  • Confirmed failure before change and success after change
  • Any generic new functionality is replicated across cloud providers if necessary
  • Tested manually against live server backend for at least one provider
  • Added tests for any new functionality
  • Linting passes locally
  • Tests pass locally
  • Updated HISTORY.md with the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing S3 move and copy operations with SSE-C

1 participant