This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Fix error in payload generated by ImportmapGenerator#29
Open
izaguirrejoe wants to merge 3 commits intodropseed:masterfrom
Open
Fix error in payload generated by ImportmapGenerator#29izaguirrejoe wants to merge 3 commits intodropseed:masterfrom
izaguirrejoe wants to merge 3 commits intodropseed:masterfrom
Conversation
Member
|
Interesting. I will try to take a look this week — it definitely looks like you're right at a glance, I just can't imagine how this could have been wrong unless something changed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation isn't working correctly,
self.targetsis already an array. This removes the extra brackets, adds pytest as a dev dependency, and adds missing tests for ImportmapGenerator.