insert() fixed on Android 10 and new SQLCipher version#5
Open
develhox wants to merge 2 commits intodrydart:masterfrom
Open
insert() fixed on Android 10 and new SQLCipher version#5develhox wants to merge 2 commits intodrydart:masterfrom
develhox wants to merge 2 commits intodrydart:masterfrom
Conversation
Author
|
I checked the Parcel source code and I didn't understand why it didn't work anymore. However in the end it does what I am doing, but with more steps, so probably the performance may not be worse in my solution, but even a little better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fix two issues.
First of all, the insert() method was broken on my Pixel 2 XL with the Android 10 update. The convertMapToContentValues() method always returned null. I fixed it by filling the ContentValues explicitly instead of relying on a Parcel. I think this may be a little slower, but at least it works.
I also changed the SQLCipher version to the 4.2.0 to get rid of an annoying log.