refactor: extract PostgresBinaryParser base class from PostgresBinaryReader#411
Merged
staticlibs merged 4 commits intoduckdb:mainfrom Mar 31, 2026
Merged
Conversation
staticlibs
requested changes
Mar 30, 2026
Collaborator
staticlibs
left a comment
staticlibs
left a comment
There was a problem hiding this comment.
Hi, thanks for the PR and sorry for the delayed review! I think it is a good idea to factor-out the binary parser. Just can we do this without introducing multiple inheritance for PostgresBinaryReader - using some kind of composition instead? I understand that it will require more changes - still should be easier to debug.
Contributor
Author
|
No worries, thank you for the review @staticlibs ! |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of addressing #405 to support decoding from a file.
In a follow up PR we shall introduce a new class to be able to read from files (bin dumps).
This PR extracts all binary data parsing logic into a standalone
PostgresBinaryParserclass.PostgresBinaryReaderholds it as a member (composition) and feeds it buffers fromPQgetCopyData.This should enables future readers (file-based) to reuse the same parsing code.