feat: #421 Adds two new extension options to configure Postgres timeo…#425
Merged
staticlibs merged 3 commits intoduckdb:mainfrom Mar 30, 2026
Merged
Conversation
staticlibs
requested changes
Mar 30, 2026
Collaborator
staticlibs
left a comment
staticlibs
left a comment
There was a problem hiding this comment.
Thanks for the PR! Added 2 nits. And please remove changes to duckdb and extension-ci-tools submodules, I would think they are accidental.
src/postgres_extension.cpp
Outdated
| "Whether or not to use TEXT protocol to read data. This is slower, but provides better " | ||
| "compatibility with non-Postgres systems", | ||
| LogicalType::BOOLEAN, Value::BOOLEAN(false)); | ||
| config.AddExtensionOption("pg_statement_timeout", |
Collaborator
There was a problem hiding this comment.
Can we rename pg_statement_timeout to pg_statement_timeout_millis? And likewise the second option.
src/postgres_extension.cpp
Outdated
| LogicalType::BOOLEAN, Value::BOOLEAN(false)); | ||
| config.AddExtensionOption("pg_statement_timeout", | ||
| "Postgres statement timeout in milliseconds to set on scan connections", | ||
| LogicalType::BIGINT, Value()); |
Collaborator
There was a problem hiding this comment.
I suggest to change the type to either INTEGER or UINTEGER.
wdroste
force-pushed
the
feat/support-timeouts-on-parallel-scans
branch
2 times, most recently
from
09f227e to
c68a9da
Compare
…or parallel scans
wdroste
force-pushed
the
feat/support-timeouts-on-parallel-scans
branch
from
c68a9da to
63700ea
Compare
staticlibs
requested changes
Mar 30, 2026
src/postgres_scanner.cpp
Outdated
| reader.reset(); | ||
| connection = PostgresConnection(); | ||
| pool_connection = PostgresPoolConnection(); | ||
| no_connection = true; |
Collaborator
There was a problem hiding this comment.
Thanks for the update!
Collaborator
There was a problem hiding this comment.
Can we remove this bit from this PR? I believe it belongs to #423.
Contributor
Author
There was a problem hiding this comment.
Absolutely sorry must be juggling to much today. Thank you for your patience.
staticlibs
approved these changes
Mar 30, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added extensions to support timeouts: