Don't store primary key on connect (behind RC flag)

[CrisBarreiro]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1212227266948491/task/1212935894619116?focus=true

Description

Steps to test this PR

Note

You'll need 3 devices to test out this PR, but only one of them (device A) needs to be an Android device running the code from this PR

Device A has sync off

• On device A: Enable "Don't keep activities" under developer settings
• On device A: Fresh install the app
• On device B: Open sync settings, go to "Sync With Another Device" > "Copy Text Code"
• On device A: Open sync settings, go to "Sync With Another Device" > "Manually Enter Code" and paste the code from device B
• On device A, complete sync process and check that when back to "Sync & Backup" screen, synced devices are displayed correctly

Device A has already synced to another device

• On device A: Enable "Don't keep activities" under developer settings
• On device A: Fresh install the app
• On device A: Sync with device C using QR code (not manually entering code)
• On device A, complete sync process and check that when back to "Sync & Backup" screen, synced devices are displayed correctly
• On device B: Open sync settings, go to "Sync With Another Device" > "Copy Text Code"
• On device A: Open sync settings, go to "Sync With Another Device" > "Manually Enter Code" and paste the code from device B
• On device A, complete sync process and check that when back to "Sync & Backup" screen, synced devices are displayed correctly

Device A has sync off - RC flag disabled

• On device A: Enable "Don't keep activities" under developer settings
• On device A: Fresh install the app
• On device A: Go to feature flag inventory and disable "storePublicKeyWhenGeneratingQRCode" under "sync"
• On device B: Open sync settings, go to "Sync With Another Device" > "Copy Text Code"
• On device A: Open sync settings, go to "Sync With Another Device" > "Manually Enter Code" and paste the code from device B
• On device A, complete sync process and check that when back to "Sync & Backup" screen, synced devices are displayed correctly

UI changes

Before	After
!(Upload before screenshot)	(Upload after screenshot)

[CrisBarreiro]

• Don't store primary key on connect (behind RC flag) #7580 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[CrisBarreiro]

All production consumers were already on a coroutine context, so I thought it was better to make this function suspend than to launch a new coroutine (or guard against main thread access) when checking the RC flag

[cmonfortep]

Left comments in Asana.