Add support for breakageData parameter#7614
Merged
GuiltyDolphin merged 4 commits intodevelopfrom Feb 26, 2026
Merged
Conversation
a0b661c to
ace8968
Compare
CrisBarreiro
approved these changes
Feb 13, 2026
Collaborator
CrisBarreiro
left a comment
There was a problem hiding this comment.
Looks good, I'll assist with testing
CrisBarreiro
requested changes
Feb 13, 2026
CrisBarreiro
requested changes
Feb 13, 2026
Collaborator
CrisBarreiro
left a comment
There was a problem hiding this comment.
@GuiltyDolphin, Android doesn't send the entire JSON payload to C-S-S, as other platforms do. As a result, we don't handle the RC flags for breakageReporting, breakageDetection, or other detectors, nor send it to C-S-S. For this to work, you'd need process those flags and send its config to C-S-S through implementations of ContentScopeConfigPlugin
ace8968 to
0eb935b
Compare
CrisBarreiro
requested changes
Feb 25, 2026
0eb935b to
10cefa9
Compare
Member
Author
|
Thanks @CrisBarreiro. I applied the changes you suggested and have re-tested. |
CrisBarreiro
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212311623899110/task/1213015238129927?focus=true
Description
Adds support for the
breakageDataparameter which is passed from CSS.The parameter is returned as part of the Content Scope Scripts breakage reporting feature as a pre-encoded string which should then be passed along as-is to the breakage report request without further encoding.
Steps to test this PR
Covered by unit tests and reference tests (duckduckgo/privacy-reference-tests#156).
I've manually tested the change and can see the
breakageDataparameter populated correctly.webDetection,webInterferenceDetection, andbreakageReportingto"enabled"in the remote configbreakageDatabreakageData=%7B%22webDetection%22%3A%5B%7B%22detectorId%22%3A%22adwalls.generic_en%22%2C%22detected%22%3Atrue%7D%5D%2C%22detectorData%22%3A%7B%22botDetection%22%3A%7B%22detected%22%3Afalse%2C%22type%22%3A%22botDetection%22%2C%22results%22%3A%5B%5D%7D%2C%22fraudDetection%22%3A%7B%22detected%22%3Afalse%2C%22type%22%3A%22fraudDetection%22%2C%22results%22%3A%5B%5D%7D%2C%22adwallDetection%22%3A%7B%22detected%22%3Atrue%2C%22type%22%3A%22adwallDetection%22%2C%22results%22%3A%5B%7B%22detected%22%3Atrue%2C%22detectorId%22%3A%22generic%22%7D%5D%7D%2C%22youtubeAds%22%3A%7B%22detected%22%3Afalse%2C%22type%22%3A%22youtubeAds%22%2C%22results%22%3A%5B%5D%7D%7D%7D&test=1)Note
Medium Risk
Medium risk because it changes the broken-site reporting payload and encoding path; incorrect handling could break report submission or produce malformed analytics data.
Overview
Adds end-to-end support for a new
breakageDatafield in broken-site reporting, captured from content-scope-scripts and stored inBrokenSiteContext.Plumbs
breakageDatathrough report construction (BrokenSiteData/BrokenSite) and updates the sender to include it inencodedParamswithout re-encoding (treating it as pre-encoded). Updates unit/reference tests to cover null vs presentbreakageDatabehavior.Written by Cursor Bugbot for commit ace8968. This will update automatically on new commits. Configure here.