Skip to content

Nested pixel suffixes in dictionary #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ladamski wants to merge 7 commits into from
Closed

Nested pixel suffixes in dictionary #7672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
135df6f
Merge branch 'hotfix/5.263.3'
joshliebe Jan 23, 2026
1397816
Merge branch 'release/5.264.0'
github-actions[bot] Jan 26, 2026
bdcac82
Updated release notes and version number for new release - 5.264.1
CrisBarreiro Jan 28, 2026
7745d95
Fix Duck.ai 'Not now' button not working in fullscreenMode (#7600)
joshliebe Jan 28, 2026
189dfb0
Merge branch 'hotfix/5.264.1'
CrisBarreiro Jan 28, 2026
73429c1
Merge branch 'release/5.265.0'
CrisBarreiro Feb 2, 2026
f72964a
nested suffixes in dict
Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PixelDefinitions/pixels/subscription_pixels.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"description": "Fired when a render process crash is reported by the WebView that shows subscription pages.",
"owners": ["lmac012"],
"triggers": ["other"],
"suffixes": ["daily_count_short", "form_factor"],
"suffixes": ["daily_count_short_form_factor"],
"parameters": [
"appVersion",
{
Expand All @@ -40,7 +40,7 @@
"description": "Fired when subscription frontend initiates sign-in using auth v1 token.",
"owners": ["lmac012"],
"triggers": ["other"],
"suffixes": ["daily_count_short", "form_factor"],
"suffixes": ["daily_count_short_form_factor"],
"parameters": ["appVersion"],
"expires": "2026-02-01"
},
Expand Down
5 changes: 5 additions & 0 deletions PixelDefinitions/suffixes_dictionary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,10 @@
"description": "Platform and device form-factor",
"key": "android",
"enum": ["phone", "tablet"]
},
"daily_count_short_form_factor": {
"type": "string",
"description": "Pixel schedule type",
"enum": [ [["d", "c"], ["android"], ["phone", "tablet"]], [["android"], ["phone", "tablet"]] ]
}
}