Add temporary pixel to track default browser page shown during onboarding#7784
Merged
mikescamell merged 5 commits intodevelopfrom Feb 25, 2026
Merged
Conversation
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1213376845722909 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mikescamell
force-pushed
the
feature/mike/add-onboarding-default-browser-page
branch
from
5e74a43 to
fbf18bd
Compare
…ad of when visible
The PREONBOARDING_DEFAULT_BROWSER_PAGE_SHOWN pixel was firing in
ViewModel init{}, which runs when the ViewPager pre-loads the fragment
off-screen. Move the pixel to a once-guarded onPageShown() method and
trigger it from setUserVisibleHint/onResume so it only fires when the
user actually sees the page.
mikescamell
force-pushed
the
feature/mike/add-onboarding-default-browser-page
branch
from
fbf18bd to
7e07a79
Compare
mikescamell
force-pushed
the
feature/mike/add-onboarding-default-browser-page
branch
from
f41f2cc to
2dd1976
Compare
Only call `onPageShown()` when `DefaultBrowserPage` is actually visible (`userVisibleHint && isResumed && view != null`) by centralizing the logic in `maybeReportPageShown()`. This removes lifecycle state juggling and prevents stale visibility paths from reporting the page as shown. Now we're using a Unique pixel type we do not need to have code in the ViewModel to stop multiple calls, it will fire once only
mikescamell
deleted the
feature/mike/add-onboarding-default-browser-page
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1213373374735573?focus=true
Description
Adds a temporary pixel to see if anyone is actually seeing the DefaultBrowserPage so we can make a more informed decision as to whether to remove it.
Removal task: https://app.asana.com/1/137249556945/project/1205278999335242/task/1213373374735577?focus=true
Steps to test this PR
Clean install
m_preonboarding_default_browser_page_shownpixel being firedUI changes
N/A
Note
Low Risk
Adds a single analytics event and minimal lifecycle hooks in the onboarding UI; primary risk is accidental over/under-counting due to fragment visibility edge cases.
Overview
Adds a new temporary onboarding telemetry pixel (
m_preonboarding_default_browser_page_shown_unique) and wires it intoDefaultBrowserPage/DefaultBrowserPageViewModelto fire as a unique event when that page becomes visible (handling bothonResumeand pager visibility viasetUserVisibleHint).Registers the pixel in
AppPixelName, documents it inonboarding.json5(with an expiry), ensuresATBis stripped viaPixelParamRemovalInterceptor, and adds unit tests verifying the pixel only fires whenonPageShown()is invoked (not on ViewModel init).Written by Cursor Bugbot for commit cc7bf42. This will update automatically on new commits. Configure here.