Add pixel instrumentation for "Get Desktop Browser"#7786
Merged
catalinradoiu merged 6 commits intodevelopfrom Feb 24, 2026
Merged
Add pixel instrumentation for "Get Desktop Browser"#7786catalinradoiu merged 6 commits intodevelopfrom
catalinradoiu merged 6 commits intodevelopfrom
Conversation
Contributor
|
Privacy Review task: https://app.asana.com/0/69071770703008/1213345628793030 |
CDRussell
approved these changes
Feb 20, 2026
CDRussell
approved these changes
Feb 23, 2026
# Conflicts: # app/src/main/java/com/duckduckgo/app/global/api/PixelParamRemovalInterceptor.kt
| coroutineScope.launch(dispatcherProvider.io()) { | ||
| settingsDataStore.getDesktopBrowserSettingDismissed = true | ||
| pendingResult.finish() | ||
| } |
Contributor
There was a problem hiding this comment.
BroadcastReceiver missing exception handling for pendingResult
Medium Severity
The pendingResult.finish() call lacks try-finally protection. If settingsDataStore.getDesktopBrowserSettingDismissed = true throws an exception, pendingResult.finish() never executes, causing the broadcast to hang for up to 10 seconds before timing out. The codebase has a goAsync() helper function (visible in VpnReminderReceiver.kt) that wraps pending result completion in try-finally, but this receiver doesn't use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1213194326544099?focus=true
Description
Added pixels for the "Get Desktop Browser" feature across all user interaction points.
Added pixels for:
Also defered reading/ writing for
getDesktopBrowserSettingDismissedfromSettingsDataStoreto io dispatcher.Steps to test this PR
PixeLs
Also the functionality for dismiss, share, hide should work as before.
UI changes
No UI changes
Note
Low Risk
Mostly adds analytics pixel firing and moves a few SettingsDataStore reads/writes onto IO dispatchers; behavior should be unchanged aside from extra async work in UI/receiver code.
Overview
Adds full pixel instrumentation for the Get Desktop Browser funnel, including impression (when the complete-setup item is shown), clicks (with
sourceofsettingsvscomplete_setup), dismissals (withsourceofno_thanksvshide), and modal actions for share and link-copy.Updates settings/desktop-browser code to fire these pixels and to perform
getDesktopBrowserSettingDismissedreads/writes on the IO dispatcher (including making the share broadcast receiver asynchronous viagoAsync), and extends pixel definitions/enum plus ATB-parameter removal and unit tests to cover the new events.Written by Cursor Bugbot for commit 6e4d330. This will update automatically on new commits. Configure here.