Skip to content

fix: required #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G4Vi merged 2 commits into from
Jan 10, 2025
Merged

fix: required #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b76cae3
hack: list required nullable properties first before non-required pro…
G4Vi Jan 10, 2025
40b6eb9
fix/feat: skip serializing None non-required values
G4Vi Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions template/plugin/pdk_types.py.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ from enum import Enum # noqa: F401
from typing import Optional, List # noqa: F401
from datetime import datetime # noqa: F401
from dataclasses import dataclass # noqa: F401
from dataclass_wizard import JSONWizard # noqa: F401
from dataclass_wizard import JSONWizard, skip_if_field, IS # noqa: F401
from dataclass_wizard.type_def import JSONObject
from base64 import b64encode, b64decode

Expand All @@ -28,11 +28,20 @@ class <%- pythonTypeName(schema.name) %>(JSONWizard):
<% }) %>

<% schema.properties.forEach(p => { -%>
<% if (p.nullable || !p.required) {%>
<% if (p.nullable && p.required) {%>
<% if (p.description) { -%>
# <%- formatCommentBlock(p.description, "# ") %>
<% } -%>
<%- p.name %>: <%- toPythonType(p, p.required) %> = None
<%- p.name %>: <%- toPythonType(p, p.required) %>
<% } %>
<% }) %>

<% schema.properties.forEach(p => { -%>
<% if (!p.required) {%>
<% if (p.description) { -%>
# <%- formatCommentBlock(p.description, "# ") %>
<% } -%>
<%- p.name %>: <%- toPythonType(p, p.required) %> = skip_if_field(IS(None), default=None)
<% } %>
<% }) %>

Expand Down
Loading