Skip to content

build: fetch interface file for easier development, run uv sync on build so packages just need to be added to pyproject.toml #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G4Vi merged 1 commit into from
Jan 24, 2025
Merged

build: fetch interface file for easier development, run uv sync on build so packages just need to be added to pyproject.toml #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions template/prepare.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,7 @@ if ! command_exists extism-py; then
sleep 2
exit 1
fi

# Download extism interface file for IDE intellisense
# Ideally we'd have extism-py generate or output this to keep it in-sync
curl -O https://raw.githubusercontent.com/extism/python-pdk/refs/heads/main/extism.pyi
Copy link
Contributor

@bhelx bhelx Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is a bit weird. why not put it in the template directory? if it's needed i have no objection though.

Copy link
Contributor Author

@G4Vi G4Vi Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer it this way as it avoids needing to keep the file up to date in another place. Eventually, maybe we pack the file into extism-py so it is matched directly with the python-pdk.

2 changes: 1 addition & 1 deletion template/xtp.toml.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ name = "<%= project.name %>"

[scripts]
# xtp plugin build runs this script to generate the wasm file
build = "PYTHONPATH=./plugin:./.venv/lib/python3.13/site-packages extism-py -o plugin.wasm plugin/__init__.py"
build = "uv sync && PYTHONPATH=./plugin:./.venv/lib/python3.13/site-packages extism-py -o plugin.wasm plugin/__init__.py"

# xtp plugin init runs this script to format the code
format = "uv run ruff format plugin/*.py"
Expand Down
Loading