feat(remotes): allow setting contentMode per remote project#236
Open
CaarLo1337 wants to merge 1 commit intoe-Spirit:masterfrom
Open
feat(remotes): allow setting contentMode per remote project#236CaarLo1337 wants to merge 1 commit intoe-Spirit:masterfrom
CaarLo1337 wants to merge 1 commit intoe-Spirit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
we’ve noticed that RemoteProjectConfiguration currently does not allow specifying the content mode (preview or release) per remote project.
At the moment the type looks like this:
In multi-tenant setups with a shared remote project (e.g. for images or shared data sources), it is important to explicitly control whether remote content is resolved in preview or release mode.
In FirstSpirit ServerManager, it is possible to explicitly define in the remote project settings whether the preview version or only the release version should be used. Therefore, it should also be possible to specify the desired content mode in the JavaScript Content API configuration.
In a pure production setup, this is usually not an issue, since both the consuming project and the remote project resolve content in release mode.
However, problems arise in preview environments.
When a tenant project runs in preview mode, the remote project is currently also resolved in preview mode. In our setup, this is not desired. We want tenant projects in preview to always consume the released content from the shared master project — not its preview state.
In other words:
Tenant project → preview
Shared remote project → always release
Currently, this behavior cannot be configured explicitly.
Feature Request
Extend RemoteProjectConfiguration to optionally support a contentMode property:
This would provide explicit control over remote content resolution and improve support for multi-tenant and production setups.