Open
Conversation
commit: |
43081j
reviewed
Sep 21, 2025
| const hasConfig = await fileSystem.fileExists('/tsconfig.json'); | ||
| expect(hasConfig).toBe(true); | ||
| }); | ||
| it('should report false for a missing file and true for an existing file', async () => { |
Contributor
There was a problem hiding this comment.
this should probably be two tests
Contributor
There was a problem hiding this comment.
looking at it, this and the readFile tests were probably organised better before, no?
roughly:
fileExists- test that it is true for files that exist
- test that it is false for files that dont exist
readFile- test that it returns files that exist
- test that it throws for files that don't exist
same with the listPackageFiles tests, they should have their own block i think
listPackageFiles- return empty list when no node_modules
- return list of packages when node_modules exists
and getInstallSize:
getInstallSize- returns 0 when no modules
- returns size when modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unit tests for TarballFileSystem (mocked unpack), expanded LocalFileSystem tests (exists/read/list/size, nested node_modules)