[TODO] used if there is a concurrency issues between gc and flush#661
Open
Besroy wants to merge 1 commit intoeBay:masterfrom
Open
[TODO] used if there is a concurrency issues between gc and flush#661Besroy wants to merge 1 commit intoeBay:masterfrom
Besroy wants to merge 1 commit intoeBay:masterfrom
Conversation
In previous implementation, there may be a concurrency issue between 'permanent_destroy' and 'cp_flush/flush_durable_commit_lsn': if m_rd_sb is destroyed at T1 then is written at T2, a NPE will occur. This pr is a fix way to avoid this issue by adding m_sb_mtx for destroy.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #661 +/- ##
==========================================
+ Coverage 56.51% 66.18% +9.67%
==========================================
Files 108 109 +1
Lines 10300 11288 +988
Branches 1402 1539 +137
==========================================
+ Hits 5821 7471 +1650
+ Misses 3894 3091 -803
- Partials 585 726 +141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiaoxichen
approved these changes
Mar 13, 2025
Collaborator
|
thanks for the effort to refine the edge case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous implementation, there may be a concurrency issue between 'permanent_destroy' and 'cp_flush/flush_durable_commit_lsn': if m_rd_sb is destroyed at T1 then is written at T2, a NPE will occur.
This pr is a fix way to avoid this issue by adding m_sb_mtx for destroy.
In addition to the current fix, there are two other potential approaches to address this issue: