Open
Conversation
- Provide the entire membership list in all pg move cb to avoid some potential inconsistency between raft and the user's meta. - Use json config instead of raft server memory config. It's because the log might be replayed during restart when the raft server is not initiated. - When raft commit a config, it calls save_config before applying to raft memory server config(reconfigure()).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
==========================================
- Coverage 56.51% 48.27% -8.25%
==========================================
Files 108 110 +2
Lines 10300 12891 +2591
Branches 1402 6188 +4786
==========================================
+ Hits 5821 6223 +402
+ Misses 3894 2571 -1323
- Partials 585 4097 +3512 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_configbefore applying to raft memory server config(nuraft reconfigure()).Previously in PR eBay/HomeObject#386, we discuss the idea to consolidate all the API into "update_membership". But I think the "update_membership" is too specific which restricts the user's behavior that can only update membership even in different phases of PGMove. So I just modify the callbacks' input.