Conversation
|
I have been stymied by inconsistent behaviour from the |
|
I've added an integration test, which will fail until the validator is updated. |
|
I am sticking with the I've updated the docker compose files, so that the profiles paths are provided, and to remove unnecessary environment variables for the celery worker. |
|
@alexhambley, @elichad, @OliverWoolland - this is ready for review now |
| ``` | ||
| 3. Provide the `PROFILES_PATH` environment to the flask container (not the celery worker container) to match the internal path, e.g.: | ||
| ``` | ||
| - PROFILES_PATH=/app/profiles |
There was a problem hiding this comment.
this is the default is it not? so no need to set unless they don't obey step 2?
There was a problem hiding this comment.
it's in the testing dockerfile, but not in the default dockerfile (that deploys our pre-built docker container)
This PR adds functionality to provide extra profiles for the rocrate-validator to use. This is via the
profiles_pathso users will need to provide a directory containing all profiles (including their own), as the original profiles directory will not be used.When the user provides profiles already present, the validator will run, but just give a warning along the lines of:
Still to-do:
Side effects of this PR: